Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add padding around showAllWrap button #8871

Merged
merged 1 commit into from
May 16, 2017
Merged

Add padding around showAllWrap button #8871

merged 1 commit into from
May 16, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 15, 2017

Fix #8869

Auditors:

Test Plan:

  1. Run npm run add-simulated-synopsis-visits until "Show All" button appears
  2. Open about:preferences#payments
  3. Disable payments
  4. Make sure there is 40 px padding under the panel
  5. Enable payments
  6. Make sure there is 40 px padding under "Show All" button

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fix #8869

Auditors:

Test Plan:
1. Run "npm run add-simulated-synopsis-visits" until "Show All" button appears
2. Open about:preferences#payments
3. Disable payments
4. Make sure there is 40 px padding under the panel
5. Enable payments
6. Make sure there is 40 px padding under "Show All" button
@luixxiul luixxiul added this to the 0.15.400 milestone May 15, 2017
@luixxiul luixxiul self-assigned this May 15, 2017
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 599e8a2 into brave:master May 16, 2017
@luixxiul luixxiul deleted the fix-ledgerTable-showAllWrap branch May 16, 2017 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants