This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Converts urlBarSuggestions into redux #9051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
redux/urlBarSuggestion
branch
2 times, most recently
from
582da77
to
02d5877
Compare
NejcZdovc
added
PR/work-in-progress ⚒
PR/needs-QA-attention ☕
and removed
PR/work-in-progress ⚒
labels
NejcZdovc
force-pushed
the
redux/urlBarSuggestion
branch
from
02d5877
to
69064fe
Compare
NejcZdovc
force-pushed
the
redux/urlBarSuggestion
branch
from
69064fe
to
aa06e4a
Compare
NejcZdovc
force-pushed
the
redux/urlBarSuggestion
branch
from
aa06e4a
to
24cb857
Compare
bridiver
approved these changes
Jun 7, 2017
| mergeProps (state, dispatchProps, ownProps) { | ||
| const currentWindow = state.get('currentWindow') | ||
| const activeFrame = frameStateUtil.getActiveFrame(currentWindow) || Immutable.Map() | ||
| const urlBar = activeFrame.getIn(['navbar', 'urlbar']) || Immutable.Map() |
There was a problem hiding this comment.
just fyi - you can use activeFrame.getIn(['navbar', 'urlbar'], Immutable.Map()) which is a little safer because it properly handles falsy values when applicable
| const activeFrame = frameStateUtil.getActiveFrame(currentWindow) || Immutable.Map() | ||
| const urlBar = activeFrame.getIn(['navbar', 'urlbar']) || Immutable.Map() | ||
| const documentHeight = Number.parseInt( | ||
| window.getComputedStyle(document.querySelector(':root')).getPropertyValue('--navbar-height'), 10 |
There was a problem hiding this comment.
we should add a TODO to take a look at this because I suspect getting the computed styles for the entire document is very slow
There was a problem hiding this comment.
I will fix all computed styles in #9176, so I think there is no need for TODO
| * @param {number} windowId - the window ID | ||
| * @param {number} selectedIndex - The index for the selected item (users can select items with down arrow on their keyboard) | ||
| */ | ||
| urlBarSelectedIndexChanged: function (windowId, selectedIndex) { |
There was a problem hiding this comment.
I like this change to pass the index instead of calculating the selections in the component
Resolves brave#9052 Auditors: @bsclifton @bridiver @bbondy Test Plan: - test if suggestion list is displayed - test if hover and click is working on suggestion list
NejcZdovc
force-pushed
the
redux/urlBarSuggestion
branch
from
24cb857
to
97015ef
Compare
51 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Auditors: @bsclifton @bridiver @bbondy
Test Plan:
Reviewer Checklist:
Tests