Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add a null check for framePath in WINDOW_SET_LINK_HOVER_PREVIEW #9589

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Add a null check for framePath in WINDOW_SET_LINK_HOVER_PREVIEW #9589

merged 1 commit into from
Jun 20, 2017

Conversation

evq
Copy link
Member

@evq evq commented Jun 20, 2017 •
edited by bridiver
Loading

Fixes browser lockup due to invalid activeFrameKey (various causes) mentioned in #9502

Auditors:
@bridiver

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

  1. Fresh profile
  2. Open browser
  3. First tab should be active

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton requested a review from bridiver June 20, 2017 05:06
@bsclifton bsclifton added this to the 0.17.x (Beta Channel) milestone Jun 20, 2017
bridiver
bridiver approved these changes Jun 20, 2017
View reviewed changes
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bridiver bridiver added the bug label Jun 20, 2017
@bridiver bridiver merged commit 26e3fa6 into brave:master Jun 20, 2017
@bridiver
Copy link
Collaborator

QA - please check after 0.17 has been updated to muon 4.1.x

bsclifton pushed a commit that referenced this pull request Jun 21, 2017
@bridiver @bsclifton
Merge pull request #9589 from evq/fix/link-hover-null-check
dd1150d 
Add a null check for framePath in WINDOW_SET_LINK_HOVER_PREVIEW
bsclifton pushed a commit that referenced this pull request Jun 21, 2017
@bridiver @bsclifton
Merge pull request #9589 from evq/fix/link-hover-null-check
19bb34b 
Add a null check for framePath in WINDOW_SET_LINK_HOVER_PREVIEW
@evq evq mentioned this pull request Jun 21, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bridiver bridiver bridiver approved these changes

Assignees

@evq evq

Labels
bug
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@evq @bridiver @bsclifton