This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
remove build scripts for HTTPS Everywhere #9653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
force-pushed
the
feature/httpse-5.1.9
branch
from
acf967c
to
378569d
Compare
diracdeltas
changed the title
|
@bbondy i updated this PR to just remove the HTTPS Everywhere script |
- commented out code from ledger - stubs used in unit testing - electron builder hack (no longer needed) Auditors: @diracdeltas
bsclifton
force-pushed
the
feature/httpse-5.1.9
branch
from
378569d
to
70bfd75
Compare
bsclifton
reviewed
Jun 29, 2017
There was a problem hiding this comment.
@diracdeltas I added a commit which removes more of the leveldown uses (including win32 hack). I'm going to test building on win32 to confirm it works as expected
| @@ -166,8 +165,7 @@ | |||
| "jsonfile": "^2.2.3", | |||
| "less": "^2.5.3", | |||
| "less-loader": "^2.2.1", | |||
| "level": "1.5.0", | |||
| "leveldown": "1.5.0", | |||
There was a problem hiding this comment.
I think we'll need some more code removed, since leveldown is being removed... I'll have a follow up commit in just a minute
There was a problem hiding this comment.
@bsclifton leveldown is included in level btw
bsclifton
approved these changes
Jun 29, 2017
bsclifton
added a commit
that referenced
this pull request
Jul 1, 2017
remove build scripts for HTTPS Everywhere
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrating to https://github.com/brave/https-everywhere-builder
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests