Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Private tabs with Tor enabled write cookies to disk #608

Closed
riastradh-brave opened this issue Jun 14, 2018 · 1 comment
Closed

Private tabs with Tor enabled write cookies to disk #608

riastradh-brave opened this issue Jun 14, 2018 · 1 comment

Comments

@riastradh-brave
Copy link
Contributor

Steps to reproduce:

  1. Open a private tab with Tor enabled.
  2. Go to https://arxiv.org/help/submit
% echo .dump | sqlite3 ~/.config/brave-development/Partitions/tor/Cookies
PRAGMA foreign_keys=OFF;
BEGIN TRANSACTION;
CREATE TABLE meta(key LONGVARCHAR NOT NULL UNIQUE PRIMARY KEY, value LONGVARCHAR);
INSERT INTO meta VALUES('mmap_status','-1');
INSERT INTO meta VALUES('version','10');
INSERT INTO meta VALUES('last_compatible_version','5');
CREATE TABLE cookies (creation_utc INTEGER NOT NULL,host_key TEXT NOT NULL,name TEXT NOT NULL,value TEXT NOT NULL,path TEXT NOT NULL,expires_utc INTEGER NOT NULL,is_secure INTEGER NOT NULL,is_httponly INTEGER NOT NULL,last_access_utc INTEGER NOT NULL, has_expires INTEGER NOT NULL DEFAULT 1, is_persistent INTEGER NOT NULL DEFAULT 1,priority INTEGER NOT NULL DEFAULT 1,encrypted_value BLOB DEFAULT '',firstpartyonly INTEGER NOT NULL DEFAULT 0,UNIQUE (host_key, name, path));
INSERT INTO cookies VALUES(13173391188612624,'.arxiv.org','browser','','/',14119471188612624,0,0,13173391188612624,1,1,1,X'763131a367902c7b76d67c57f98c26c6eba598b588841f1f1fe3adf72aee7a7dc70df9',0);
COMMIT;

The cookie should not be there.

  • Electron version: 6.0.11
  • Operating system: Ubuntu 17.10
riastradh-brave added a commit that referenced this issue Jun 14, 2018
This is necessary because we use `persist:tor' since for hysterical
raisins there's only one normal `private' partition with in_memory_ =
true.  We use the virtual method IsOffTheRecord() to discriminate
instead.

Fixes #608.
Fixes brave/browser-laptop#14392.

Auditors: @darkdh
@riastradh-brave
Copy link
Contributor Author

Fixed in 96c2eb7.

@bsclifton bsclifton added this to the next tor build milestone Jun 15, 2018
darkdh pushed a commit that referenced this issue Jun 18, 2018
This is necessary because we use `persist:tor' since for hysterical
raisins there's only one normal `private' partition with in_memory_ =
true.  We use the virtual method IsOffTheRecord() to discriminate
instead.

Fixes #608.
Fixes brave/browser-laptop#14392.

Auditors: @darkdh
darkdh pushed a commit that referenced this issue Jun 20, 2018
This is necessary because we use `persist:tor' since for hysterical
raisins there's only one normal `private' partition with in_memory_ =
true.  We use the virtual method IsOffTheRecord() to discriminate
instead.

Fixes #608.
Fixes brave/browser-laptop#14392.

Auditors: @darkdh
darkdh pushed a commit that referenced this issue Jun 21, 2018
This is necessary because we use `persist:tor' since for hysterical
raisins there's only one normal `private' partition with in_memory_ =
true.  We use the virtual method IsOffTheRecord() to discriminate
instead.

Fixes #608.
Fixes brave/browser-laptop#14392.

Auditors: @darkdh
darkdh pushed a commit that referenced this issue Jun 27, 2018
This is necessary because we use `persist:tor' since for hysterical
raisins there's only one normal `private' partition with in_memory_ =
true.  We use the virtual method IsOffTheRecord() to discriminate
instead.

Fixes #608.
Fixes brave/browser-laptop#14392.

Auditors: @darkdh
darkdh pushed a commit that referenced this issue Jul 6, 2018
This is necessary because we use `persist:tor' since for hysterical
raisins there's only one normal `private' partition with in_memory_ =
true.  We use the virtual method IsOffTheRecord() to discriminate
instead.

Fixes #608.
Fixes brave/browser-laptop#14392.

Auditors: @darkdh
darkdh pushed a commit that referenced this issue Jul 25, 2018
This is necessary because we use `persist:tor' since for hysterical
raisins there's only one normal `private' partition with in_memory_ =
true.  We use the virtual method IsOffTheRecord() to discriminate
instead.

Fixes #608.
Fixes brave/browser-laptop#14392.

Auditors: @darkdh
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants