This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Update the uploadBrowser to take channel-specific binary naming into account #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…account Fixes brave/browser-laptop#11795 Auditors: @aekeus, @darkdh
bsclifton
commented
Nov 7, 2017
| } | ||
|
|
||
| const getChannelName = () => { | ||
| if (args.channel === 'dev') { |
There was a problem hiding this comment.
if dev, no change will be made to the binary name
bsclifton
commented
Nov 7, 2017
| @@ -73,34 +73,34 @@ var OS_IDENTIFIER = 2 | |||
| var recipes = [ | |||
| // Linux | |||
| ['dist/Brave.tar.bz2', 'multi-channel/releases/CHANNEL/VERSION/linux64', 'linux'], | |||
| ['dist/brave_VERSION_amd64.deb', 'multi-channel/releases/CHANNEL/VERSION/debian64', 'linux'], | |||
| ['dist/brave-VERSION.x86_64.rpm', 'multi-channel/releases/CHANNEL/VERSION/fedora64', 'linux'], | |||
| ['dist/brave{{channelName}}_VERSION_amd64.deb', 'multi-channel/releases/CHANNEL/VERSION/debian64', 'linux'], | |||
There was a problem hiding this comment.
I used a handlebars.js type of token since it's easy to parse out and it's pretty widely recognized
There was a problem hiding this comment.
maybe we can upgrade this pattern to tools/buildPackages.js and tools/buildInstaller.js too
darkdh
approved these changes
Nov 7, 2017
| @@ -73,34 +73,34 @@ var OS_IDENTIFIER = 2 | |||
| var recipes = [ | |||
| // Linux | |||
| ['dist/Brave.tar.bz2', 'multi-channel/releases/CHANNEL/VERSION/linux64', 'linux'], | |||
| ['dist/brave_VERSION_amd64.deb', 'multi-channel/releases/CHANNEL/VERSION/debian64', 'linux'], | |||
| ['dist/brave-VERSION.x86_64.rpm', 'multi-channel/releases/CHANNEL/VERSION/fedora64', 'linux'], | |||
| ['dist/brave{{channelName}}_VERSION_amd64.deb', 'multi-channel/releases/CHANNEL/VERSION/debian64', 'linux'], | |||
There was a problem hiding this comment.
maybe we can upgrade this pattern to tools/buildPackages.js and tools/buildInstaller.js too
|
This script will undergo a number of changes when the database back updater is deployed as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/browser-laptop#11795
Auditors: @aekeus, @darkdh
I hand-ran the script on each platform (the latest build was beta - click for logs):
I also reviewed the s3 buckets under
brave-downloadand things looked OK to me (for 0.20.6)