Avoid stack overflow in R2Stretcher::study. #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `study` method calls `alloca` in a loop, which causes a large amount of data to be allocated on the stack - proportional to the provided input. (`alloca` does not follow C++'s RAII rules; the allocated memory stays on the stack until the function exits, rather than the enclosing scope.) With a large enough input, this can cause a stack overflow. This commit avoids the problem by only calling `alloca` at most once and re-using the buffer if necessary.
|
Oof, that's nasty. Thanks for the report! I may look at doing this without alloca (which was always a bit gross). |
|
Fixed in 832f577. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
studymethod callsallocain a loop, which causes a large amount of data to be allocated on the stack - proportional to the provided input. (allocadoes not follow C++'s RAII rules; the allocated memory stays on the stack until the function exits, rather than the enclosing scope.) With a large enough input, this can cause a stack overflow.This PR avoids the problem by only calling
allocaat most once and re-using the buffer if necessary.(Discovered by @f0k in spotify/pedalboard#340.)