-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail gracefully when connecting to other database #3026
Conversation
Hey @romain-gilliotte thanks for doing this! This has actually be a long time thorn in the side of folks, and any |
Thank you so much for looking into this! |
Hello @brianc and @romain-gilliotte. |
(Re-ran the test with the Cloudflare-worker-related segfault, it passed.) |
Hello, |
It seems this PR is ready to merge, can we go please? |
Thanks
Le ven. 15 sept. 2023, 23:23, Brian C ***@***.***> a écrit :
… Merged #3026 <#3026> into
master.
—
Reply to this email directly, view it on GitHub
<#3026 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYNLYQLVLMW22U3DFUIPB3X2TBMJANCNFSM6AAAAAAZ67P5DE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
ty |
Hello, |
Fixes #2627
I'm currently working at Forest Admin.
We're a French company building a SaaS that generates admin panels.
During onboarding, we connect to our customer's databases to introspect the structure.
However, customers don't always know which database vendor they are using, and click on the wrong one during onboarding.
This causes pg-protocol to throw an unhandled exception, and our backend workers to go down.
I tried to follow the coding style and test this.
Don't hesitate to come back to me if anything is not at it should be!
Note that I never managed to run all the tests locally... so I'm likely to break others.
I'm creating the PR so that the CI runs, and that I can check if everything is OK