Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hbase20] no slf4j implementation; hbase client doesn't log #1173

Closed
busbey opened this issue Jun 13, 2018 · 2 comments · Fixed by #1396
Closed

[hbase20] no slf4j implementation; hbase client doesn't log #1173

busbey opened this issue Jun 13, 2018 · 2 comments · Fixed by #1396

Comments

@busbey
Copy link
Collaborator

busbey commented Jun 13, 2018

running through testing the hbase20 binding, there's no logs from the client library (as there are in the earlier bindings).

Loading workload...
Starting test.
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
DBWrapper: report latency for each error is false and specific error codes to track for latency are: []

Looks like the hbase 1.2 and hbase 1.4 shaded jars incorrectly included a dependency on the slf4j-log4j12 bridge. so to have the same logging on the hbase 2.0 client we'll need to add it.

@busbey
Copy link
Collaborator Author

busbey commented Sep 11, 2018

As a workaround, you can download the slf4j simple logger directly:

e.g. for the hbase 2.0 specific tarball:

(cd lib/ && curl -O 'https://search.maven.org/remotecontent?filepath=org/slf4j/slf4j-simple/1.7.25/slf4j-simple-1.7.25.jar')

for 0.15.0 you'd end up with

ycsb-hbase20-binding-0.15.0 busbey$ ls -lah lib/
total 96080
drwxr-xr-x  16 busbey  staff   512B Sep 11 08:20 .
drwxr-xr-x   8 busbey  staff   256B Sep 11 08:20 ..
-rw-r--r--@  1 busbey  staff   102K May 12  2017 HdrHistogram-2.1.4.jar
-rw-r--r--@  1 busbey  staff    20K Jul 11  2017 audience-annotations-0.5.0.jar
-rw-r--r--@  1 busbey  staff    61K Dec  1  2016 commons-logging-1.1.3.jar
-rw-r--r--@  1 busbey  staff   143K Aug 13 22:25 core-0.15.0.jar
-rw-r--r--@  1 busbey  staff    15K Nov 29  2016 findbugs-annotations-1.3.9-1.jar
-rw-r--r--@  1 busbey  staff    44M Jul 15 20:55 hbase-shaded-client-2.0.0.jar
-rw-r--r--@  1 busbey  staff   8.7K Aug 13 22:32 hbase10-binding-0.15.0.jar
-rw-r--r--@  1 busbey  staff   3.1K Aug 13 22:32 hbase20-binding-0.15.0.jar
-rw-r--r--@  1 busbey  staff   1.4M Dec  2  2016 htrace-core4-4.1.0-incubating.jar
-rw-r--r--@  1 busbey  staff   223K May 12  2017 jackson-core-asl-1.9.4.jar
-rw-r--r--@  1 busbey  staff   759K May 12  2017 jackson-mapper-asl-1.9.4.jar
-rw-r--r--@  1 busbey  staff   478K Nov 29  2016 log4j-1.2.17.jar
-rw-r--r--@  1 busbey  staff    40K May  4  2017 slf4j-api-1.7.25.jar
-rw-r--r--   1 busbey  staff    15K Sep 11 08:20 slf4j-simple-1.7.25.jar

similarly, for the full YCSB tarball:

(cd hbase20-binding/lib && curl -O 'https://search.maven.org/remotecontent?filepath=org/slf4j/slf4j-simple/1.7.25/slf4j-simple-1.7.25.jar')

for 0.15.0 you'd end up with

ycsb-0.15.0 busbey$ ls -lah hbase20-binding/lib/
total 93616
drwxr-xr-x@ 12 busbey  staff   384B Sep 11 08:22 .
drwxr-xr-x   4 busbey  staff   128B Sep 11 08:16 ..
-rw-r--r--@  1 busbey  staff    20K Aug 13 22:32 audience-annotations-0.5.0.jar
-rw-r--r--@  1 busbey  staff    61K Aug 13 22:32 commons-logging-1.1.3.jar
-rw-r--r--@  1 busbey  staff    15K Aug 13 22:32 findbugs-annotations-1.3.9-1.jar
-rw-r--r--@  1 busbey  staff    44M Aug 13 22:32 hbase-shaded-client-2.0.0.jar
-rw-r--r--@  1 busbey  staff   8.7K Aug 13 22:32 hbase10-binding-0.15.0.jar
-rw-r--r--@  1 busbey  staff   3.1K Aug 13 22:32 hbase20-binding-0.15.0.jar
-rw-r--r--@  1 busbey  staff   1.4M Aug 13 22:32 htrace-core4-4.1.0-incubating.jar
-rw-r--r--@  1 busbey  staff   478K Aug 13 22:32 log4j-1.2.17.jar
-rw-r--r--@  1 busbey  staff    40K Aug 13 22:32 slf4j-api-1.7.25.jar
-rw-r--r--   1 busbey  staff    15K Sep 11 08:22 slf4j-simple-1.7.25.jar

busbey added a commit to busbey/YCSB that referenced this issue Feb 3, 2020
* remove 0.98, 1.0, 1.2, and 2.0 bindings
* add 2.2 binding
* incorporate README from 0.98 binding into current bindings
* incorporate README on bigtable testing from 1.0 binding into 1.4 binding
* incorporate implementation from 1.0 client into current bindings
* updated asynchbase binding to include parts of removed bindings it referenced
* update 1.4 and 2.2 to current releases
* use shaded client test for all hbase bindings.
* make hbase bindings consistently use log4j
* fixes brianfrankcooper#1173
* fixes brianfrankcooper#1172
busbey added a commit to busbey/YCSB that referenced this issue Feb 3, 2020
* remove 0.98, 1.0, 1.2, and 2.0 bindings
* add 2.2 binding
* incorporate README from 0.98 binding into current bindings
* incorporate README on bigtable testing from 1.0 binding into 1.4 binding
* incorporate implementation from 1.0 client into current bindings
* updated asynchbase binding to include parts of removed bindings it referenced
* update 1.4 and 2.2 to current releases
* use shaded client test for all hbase bindings.
* make hbase bindings consistently use log4j
* fixes brianfrankcooper#1173
* fixes brianfrankcooper#1172
busbey added a commit to busbey/YCSB that referenced this issue Feb 3, 2020
* remove 0.98, 1.0, 1.2, and 2.0 bindings
* add 2.2 binding
* incorporate README from 0.98 binding into current bindings
* incorporate README on bigtable testing from 1.0 binding into 1.4 binding
* incorporate implementation from 1.0 client into current bindings
* updated asynchbase binding to include parts of removed bindings it referenced
* update 1.4 and 2.2 to current releases
* use shaded client test for all hbase bindings.
* make hbase bindings consistently use log4j
* fixes brianfrankcooper#1173
* fixes brianfrankcooper#1172
busbey added a commit that referenced this issue Feb 5, 2020
* remove 0.98, 1.0, 1.2, and 2.0 bindings
* change the 1.4 binding to be  a "HBase 1.y" binding
* add "HBase 2.y" binding and default it to the current 2.2 release
* incorporate README from 0.98 binding into current bindings
* incorporate README on bigtable testing from 1.0 binding into 1.4 binding
* incorporate implementation from 1.0 client into current bindings
* updated asynchbase binding to include parts of removed bindings it referenced
* update maprdb binding for the change in the hbase bindings
* update 1.4 and 2.2 to current releases
* use shaded client test for all hbase bindings.
* make hbase bindings consistently use log4j
* fixes #1173
* fixes #1172
@sanxiago
Copy link

sanxiago commented Feb 7, 2020

curl -L -O 'https://search.maven.org/remotecontent?filepath=org/slf4j/slf4j-simple/1.7.25/slf4j-simple-1.7.25.jar'

Looks like the maven.org has a redirect, using -L gets to the actual jar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants