Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ycsb launcher should only include binding specific jars in the classpath #302

Closed
busbey opened this issue Jun 17, 2015 · 6 comments
Closed

Comments

@busbey
Copy link
Collaborator

busbey commented Jun 17, 2015

right now when you use the ycsb launcher, we build a classpath with all the jars from all the bindings.

instead, find_jars should build a classpath with just the core libraries (in lib/) and those for the selected binding (in datastore-binding/lib as of #300)

@gkamat
Copy link
Collaborator

gkamat commented Jun 17, 2015

That's what seems to be happening with the current launcher. For instance, when running a HBase workload, the following jars are included in the classpath:
.../ycsb-0.2.0-SNAPSHOT/core/lib/core-0.2.0-SNAPSHOT.jar:.../ycsb-0.2.0-SNAPSHOT/hbase-binding/conf:.../ycsb-0.2.0-SNAPSHOT/hbase-binding/lib/hbase-binding-0.2.0-SNAPSHOT.jar

Perhaps this was different in the launcher before a recent change?

@busbey
Copy link
Collaborator Author

busbey commented Jun 17, 2015

that's with the pre-#300 launcher? or with the current launcher in the hbase dist tarball? or with the current launcher in the everything-dist tarball?

@gkamat
Copy link
Collaborator

gkamat commented Jun 17, 2015

This was the current launcher, but I had changed the pom.xml to build only HBase. Reverting it to build everything still includes only the core and hbase-binding jars (but all conf directories -- that could be fixed, if needed):

.../ycsb-0.2.0-SNAPSHOT/gemfire-binding/conf:.../ycsb-0.2.0-SNAPSHOT/core/lib/core-0.2.0-SNAPSHOT.jar:.../ycsb-0.2.0-SNAPSHOT/voldemort-binding/conf:.../ycsb-0.2.0-SNAPSHOT/tarantool-binding/conf:.../ycsb-0.2.0-SNAPSHOT/jdbc-binding/conf:.../ycsb-0.2.0-SNAPSHOT/accumulo-binding/conf:.../ycsb-0.2.0-SNAPSHOT/hbase-binding/conf:.../ycsb-0.2.0-SNAPSHOT/hbase-binding/lib/hbase-binding-0.2.0-SNAPSHOT.jar

@cmccoy
Copy link
Collaborator

cmccoy commented Jun 19, 2015

This is biting me - accumulo and hbase include different hadoop versions.

@busbey
Copy link
Collaborator Author

busbey commented Jun 19, 2015

Thinking about this more, I think this is a regression . before the
packaging refactoring, all the bindings were jar - with - dependencies, so
excluding the other binding jars was enough.

@gkamat, will you have time to work through this soon? If not, would you
mind if I made a patch to fix it (but not the conf dir part)?
On Jun 19, 2015 6:26 PM, "Connor McCoy" notifications@github.com wrote:

This is biting me - accumulo and hbase include different hadoop versions.


Reply to this email directly or view it on GitHub
#302 (comment)
.

@gkamat
Copy link
Collaborator

gkamat commented Jun 20, 2015

Commit 2559ce6 should fix this. Had some issues rebasing, but the change to bin/ycsb is all that is needed.

@busbey busbey closed this as completed in 7dcbb32 Jun 20, 2015
jaricftw pushed a commit to jaricftw/YCSB that referenced this issue Jul 19, 2016
closes brianfrankcooper#302 ycsb launcher should only include binding specific jars in the classpath
jaricftw pushed a commit to jaricftw/YCSB that referenced this issue Jul 19, 2016
closes brianfrankcooper#302 ycsb launcher should only include binding specific jars in the classpath
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants