[db voltdb] Add VoltDB client #1319

srmadscience · 2019-07-02T08:35:45Z

VoltDB has had a YCSB implementation for a few years now - see https://github.com/VoltDB/voltdb/tree/master/tests/test_apps/ycsb . While we supported the benchmark we'd never get round to formally integrating it with the 'official' YCSB repo. This pull request will hopefully address that.

In addition to moving the code around and fixing it so the init() method creates the schema if needed I've also made what I believe to the required changes to two pom.xml files. What I haven't been able to do is figure out how this line - which is needed - AFAIK - ends up in 'bindings.properties', as the 'bin' directory isn't in my fork:

voltdb:com.yahoo.ycsb.db.VoltClient4

I have built this on ubuntu on AWS using the Oracle JDK, and have created the schema and run workloads a - e successfully.

I am based in Dublin, Ireland and can be reached at drolfe at voltdb.com.

Regards,

DR

busbey

thanks for the effort on merging this in.

it looks like the bin directory is in your fork here:

https://github.com/srmadscience/YCSB/tree/db_voltdb/bin

don't forget to update both bindings.properties and the mapping in ycsb

voltdb/README.md

voltdb/pom.xml

voltdb/src/main/java/com/yahoo/ycsb/db/VoltClient4.java

voltdb/src/main/java/org/voltdbycsb/procs/ByteWrapper.java

voltdb/src/main/java/org/voltdbycsb/procs/Put.java

voltdb/src/main/java/org/voltdbycsb/procs/Scan.java

voltdb/src/main/java/org/voltdbycsb/procs/ScanAll.java

voltdb/src/main/java/org/voltdbycsb/procs/package-info.java

srmadscience · 2019-07-03T17:19:27Z

Sean, Thank you for getting back to me so quickly! 1. I am meeting our VP of Eng this Sunday (she's visiting Dublin...) and I'll ask if the *GPL issue is a problem for us - AFAIK it's not... 2. I will aim to have another commit done by COB next Wednesday. I'm away until Tue ... 3. My goal is to get this across the line with the minimum of ping-ponging back and forth... Regards, David Rolfe *David Rolfe* | Director of Solutions Engineering (EMEA) *e:* drolfe@voltdb.com <tcammett@voltdb.com>*m:* +353.86.173.6280 voltdb.com <https://www.facebook.com/VoltDB/> <https://twitter.com/VoltDB> <https://www.linkedin.com/company/voltdb>

…

On Wed, Jul 3, 2019 at 2:38 PM Sean Busbey ***@***.***> wrote: ***@***.**** requested changes on this pull request. thanks for the effort on merging this in. it looks like the bin directory is in your fork here: https://github.com/srmadscience/YCSB/tree/db_voltdb/bin don't forget to update both bindings.properties and the mapping in ycsb ------------------------------ In voltdb/README.md <#1319 (comment)> : > @@ -0,0 +1,68 @@ +# YCSB for VoltDB needs a license header ------------------------------ In voltdb/pom.xml <#1319 (comment)> : > + <dependency> + <groupId>junit</groupId> + <artifactId>junit</artifactId> + <version>4.12</version> + <scope>test</scope> + </dependency> + +<dependency> + <groupId>org.voltdb</groupId> + <artifactId>voltdbclient</artifactId> + <version>9.0</version> +</dependency> + +<dependency> + <groupId>org.voltdb</groupId> + <artifactId>voltdb</artifactId> just curious, why this dependency if we already have the volddbclient dependency? ------------------------------ In voltdb/pom.xml <#1319 (comment)> : > + <dependency> + <groupId>com.yahoo.ycsb</groupId> + <artifactId>core</artifactId> + <version>${project.version}</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>junit</groupId> + <artifactId>junit</artifactId> + <version>4.12</version> + <scope>test</scope> + </dependency> + +<dependency> + <groupId>org.voltdb</groupId> + <artifactId>voltdbclient</artifactId> voltdbclient appears to be AGPL licensed according to its maven central pom: https://search.maven.org/artifact/org.voltdb/voltdbclient/9.0/jar I'll need to review our other dependencies; I don't think we've allowed *GPL dependencies before. ------------------------------ In voltdb/src/main/java/com/yahoo/ycsb/db/VoltClient4.java <#1319 (comment)> : > + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing + * permissions and limitations under the License. See accompanying + * LICENSE file. + */ + +/* + * This client provideds a wrapper layer for running the Yahoo Cloud Serving + * Benchmark (YCSB) against VoltDB. This benchmark runs a synchronous client + * with a mix of the operations provided below. YCSB is open-source, and may + * be found at https://github.com/brianfrankcooper/YCSB. The YCSB jar must be + * in your classpath to compile this client. + */ +package com.yahoo.ycsb.db; this should be in com.yahoo.ycsb.db.voltdb ------------------------------ In voltdb/src/main/java/com/yahoo/ycsb/db/VoltClient4.java <#1319 (comment)> : > +import org.voltdb.client.Client; +import org.voltdb.client.ClientResponse; +import org.voltdb.client.ClientResponseWithPartitionKey; +import org.voltdb.client.ProcCallException; +import org.voltdb.sortedvolttable.VoltDBTableSortedMergeWrangler; +import org.voltdb.ycsb.ConnectionHelper; +import org.voltdb.ycsb.YCSBSchemaBuilder; + +import com.yahoo.ycsb.ByteArrayByteIterator; +import com.yahoo.ycsb.ByteIterator; +import com.yahoo.ycsb.DB; +import com.yahoo.ycsb.DBException; +import com.yahoo.ycsb.Status; + +/** + * @author srmadscience / VoltDB please leave out author tags; we rely on git commit metadata for that kind of tracking. ------------------------------ In voltdb/src/main/java/com/yahoo/ycsb/db/package-info.java <#1319 (comment)> : > @@ -0,0 +1,7 @@ +/** + * VoltDB integration with YCSB. + * + * @author srmadscience / VoltDB + * + */ +package com.yahoo.ycsb.db; shouldn't need this package-info file because everything should be in com.yahoo.ycsb.db.voltdb ------------------------------ In voltdb/src/main/java/org/voltdb/sortedvolttable/ClientResponseIsBadException.java <#1319 (comment)> : > @@ -0,0 +1,31 @@ +package org.voltdb.sortedvolttable; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdb/sortedvolttable/IncomingVoltTablesNeedToBeSortedException.java <#1319 (comment)> : > @@ -0,0 +1,31 @@ +package org.voltdb.sortedvolttable; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdb/sortedvolttable/NeedsToBeComparableException.java <#1319 (comment)> : > @@ -0,0 +1,34 @@ +package org.voltdb.sortedvolttable; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdb/sortedvolttable/VoltDBTableSortedMergeWrangler.java <#1319 (comment)> : > @@ -0,0 +1,207 @@ +package org.voltdb.sortedvolttable; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdb/sortedvolttable/package-info.java <#1319 (comment)> : > @@ -0,0 +1,14 @@ +/** + * + * VoltDBTableSortedMergeWrangler allows you to merge an array of VoltTable + * provided by callAllPartitionProcedure. + * + * The intended use case is for when you need to issue a multi partition query + * but would prefer not to, as you don't need perfect read consistency and would + * rather get the individual VoltDB partitions to issue the query independently + * and then somehow merge the results. + * + * @author srmadscience / VoltDB + * + */ +package org.voltdb.sortedvolttable; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdb/ycsb/ConnectionHelper.java <#1319 (comment)> : > + * may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing + * permissions and limitations under the License. See accompanying + * LICENSE file. + */ + +/* + * Manage a mapping of one VoltDB client to every 50 YCSB client threads. + */ +package org.voltdb.ycsb; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdb/ycsb/YCSBSchemaBuilder.java <#1319 (comment)> : > + * Copyright (c) 2015-2019 YCSB contributors. All rights reserved. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you + * may not use this file except in compliance with the License. You + * may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing + * permissions and limitations under the License. See accompanying + * LICENSE file. + */ +package org.voltdb.ycsb; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdb/ycsb/package-info.java <#1319 (comment)> : > @@ -0,0 +1,7 @@ +/** + * VoltDB integration with YCSB. + * + * @author srmadscience / VoltDB + * + */ +package org.voltdb.ycsb; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdbycsb/procs/ByteWrapper.java <#1319 (comment)> : > + * + * Licensed under the Apache License, Version 2.0 (the "License"); you + * may not use this file except in compliance with the License. You + * may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing + * permissions and limitations under the License. See accompanying + * LICENSE file. + */ + +package org.voltdbycsb.procs; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdbycsb/procs/Put.java <#1319 (comment)> : > + * + * Licensed under the Apache License, Version 2.0 (the "License"); you + * may not use this file except in compliance with the License. You + * may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing + * permissions and limitations under the License. See accompanying + * LICENSE file. + */ + +package org.voltdbycsb.procs; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdbycsb/procs/Scan.java <#1319 (comment)> : > + * + * Licensed under the Apache License, Version 2.0 (the "License"); you + * may not use this file except in compliance with the License. You + * may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing + * permissions and limitations under the License. See accompanying + * LICENSE file. + */ + +package org.voltdbycsb.procs; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdbycsb/procs/ScanAll.java <#1319 (comment)> : > + * + * Licensed under the Apache License, Version 2.0 (the "License"); you + * may not use this file except in compliance with the License. You + * may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing + * permissions and limitations under the License. See accompanying + * LICENSE file. + */ + +package org.voltdbycsb.procs; this should be in com.yahoo.ycsb.db.voltdb or a package under that ------------------------------ In voltdb/src/main/java/org/voltdbycsb/procs/package-info.java <#1319 (comment)> : > + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing + * permissions and limitations under the License. See accompanying + * LICENSE file. + */ + +/** + * VoltDB org.voltdbycsb.procs for Put and Scan. Other org.voltdbycsb.procs + * are defined using DDL in ycsb_ddl.sql + */ +package org.voltdbycsb.procs; this should be in com.yahoo.ycsb.db.voltdb or a package under that — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1319?email_source=notifications&email_token=AFOIDYUDRFCNIPSUUEIOJJ3P5STXBA5CNFSM4H4ZLZE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5MO43A#pullrequestreview-257486444>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFOIDYXSJ23OTT2LRZ4IXCDP5STXBANCNFSM4H4ZLZEQ> .

…per#1319

srmadscience · 2019-07-16T08:17:45Z

Sean,

I talked to our VP Eng and we have no issues using your licensing for the VoltDB specific YCSB code.
I have made what I believe to be the 'correct' changes, and tested them to my own satisfaction. They are now in the codebase.
One item of GitHub etiquette: Can I confirm it's your job to 'Resolve' comments, not mine?

Regards,

David Rolfe

…in README

busbey · 2019-08-20T14:39:21Z

Hi David!

Sorry for the lag on chasing this down.

One item of GitHub etiquette: Can I confirm it's your job to 'Resolve' comments, not mine?

I think that varies by project. Personally I'm fine either way. Resolving them myself helps me get context when picking a review back up, but I am also fine just reviewing the then-current code without those markers.

I talked to our VP Eng and we have no issues using your licensing for the VoltDB specific YCSB code.

The issue isn't your VoltDB specific YCSB code (though since our project license is ALv2, we would require contributions to be under that license). The issue is that adding the Volt DB client libraries as a dependency would bring them in as a part of our binary packaging and add them as a transitive dependency should others rely on us. Having those libraries be AGPL presents a problem since it is more restrictive then the license we have for everything else. For example, any ASF projects that rely on us would have to take pains to make sure they don't get that part of the code base.

As I mentioned though, I haven't done a dependency review in some time to ensure we don't have other *GPL dependencies sitting around. I will try to find time to do that.

Is there any chance of VoltDB sticking with whatever licensing for the server code and releasing client specific libraries under ALv2 instead of AGPL? IIRC there are some other data stores that did similar, either with GPL or closed source servers that are accessed via a client that's under a permissive open source license.

srmadscience · 2019-08-20T14:42:45Z

Sean, I'll go ask the appropriate people. If you get a chance can you eyeball my other changes? Regards, David Rolfe *David Rolfe* | Director of Solutions Engineering (EMEA) *e:* drolfe@voltdb.com <tcammett@voltdb.com>*m:* +353.86.173.6280 voltdb.com <https://www.facebook.com/VoltDB/> <https://twitter.com/VoltDB> <https://www.linkedin.com/company/voltdb>

…

On Tue, Aug 20, 2019 at 3:39 PM Sean Busbey ***@***.***> wrote: Hi David! Sorry for the lag on chasing this down. One item of GitHub etiquette: Can I confirm it's your job to 'Resolve' comments, not mine? I think that varies by project. Personally I'm fine either way. Resolving them myself helps me get context when picking a review back up, but I am also fine just reviewing the then-current code without those markers. I talked to our VP Eng and we have no issues using your licensing for the VoltDB specific YCSB code. The issue isn't your VoltDB specific YCSB code (though since our project license is ALv2, we would require contributions to be under that license). The issue is that adding the Volt DB client libraries as a dependency would bring them in as a part of our binary packaging and add them as a transitive dependency should others rely on us. Having those libraries be AGPL presents a problem since it is more restrictive then the license we have for everything else. For example, any ASF projects that rely on us would have to take pains to make sure they don't get that part of the code base. As I mentioned though, I haven't done a dependency review in some time to ensure we don't have other *GPL dependencies sitting around. I will try to find time to do that. Is there any chance of VoltDB sticking with whatever licensing for the server code and releasing client specific libraries under ALv2 instead of AGPL? IIRC there are some other data stores that did similar, either with GPL or closed source servers that are accessed via a client that's under a permissive open source license. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1319?email_source=notifications&email_token=AFOIDYXCREANV7KSBGWN56TQFP62NA5CNFSM4H4ZLZE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4WQVKQ#issuecomment-523045546>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFOIDYXR2H25FFFQ2MLNHTDQFP62NANCNFSM4H4ZLZEQ> .

bin/ycsb

jdbc/README.md

voltdb/src/main/java/com/yahoo/ycsb/db/voltdb/ConnectionHelper.java

voltdb/src/main/java/com/yahoo/ycsb/db/voltdb/VoltClient4.java

voltdb/src/main/java/com/yahoo/ycsb/db/voltdb/ConnectionHelper.java

voltdb/src/main/java/com/yahoo/ycsb/db/voltdb/VoltClient4.java

voltdb/src/main/java/org/voltdb/sortedvolttable/ClientResponseIsBadException.java

voltdb/src/test/java/com/yahoo/ycsb/db/voltdb/test/VoltDBClientTest.java

srmadscience · 2019-08-21T13:50:25Z

Sean,

Spoke to our VP/Eng. We're looking at what's involved in changing to Apache for the client. In the mean time I'll work on the other items...

DR

srmadscience · 2019-08-28T10:18:28Z

Sean,

We can fix it so the client uses the MIT licence. Will that work for you guys?

David Rolfe

busbey · 2019-08-28T11:30:34Z

Yeah, that'd be great.

… db_voltdb

srmadscience · 2019-09-06T11:27:56Z

As far as I can tell We've fixed all the issues that have been raised so far. Can someone review? Thanks!

busbey

I think we're getting close!

I also plan to download the client jar to make sure the license metadata in it matches the pom.

Do y'all have plans to call out the license change on the client jar anywhere?

pom.xml

voltdb/pom.xml

voltdb/src/main/java/com/yahoo/ycsb/db/voltdb/ConnectionHelper.java

voltdb/src/main/java/com/yahoo/ycsb/db/voltdb/VoltClient4.java

voltdb/src/main/java/com/yahoo/ycsb/db/voltdb/YCSBSchemaBuilder.java

voltdb/src/main/java/com/yahoo/ycsb/db/voltdb/package-info.java

voltdb/src/test/java/com/yahoo/ycsb/db/voltdb/test/VoltDBClientTest.java

srmadscience · 2019-09-06T15:57:51Z

I've hit an issue I need some advice on. If I change the VoltDB lib to runtime or test dependency the build fails because it sees the stored procedure classes, tries to compile them, and fails because the server libs aren't in the path. My thinking is to dynamically write the stored procedure classes - i.e. they would cease to exist as Java classes and turn into Strings that are used to compile classes when we have determined we are connected to a real, live copy of VoltDB. Is this the 'least worst' solution to this problem?

busbey · 2019-09-06T16:04:11Z

Try provided scope? that scope means "I need this to compile and test, but at runtime it'll be present in the environment". I think that's the intention?

srmadscience · 2019-09-06T16:45:34Z

'provided' worked.

srmadscience · 2019-09-06T18:20:32Z

As far as I can tell everything raised on this pass has been done...

busbey · 2019-09-06T18:57:36Z

pom.xml

@@ -110,6 +110,7 @@ LICENSE file.
    <thrift.version>0.8.0</thrift.version>
    <voldemort.version>0.81</voldemort.version>
    <tablestore.version>4.8.0</tablestore.version>
+    <voltdb.version>9.1</voltdb.version>


I thought it was specifically version 9.1.1 we needed? Also it doesn't look like the voltdb-binding pom is using this currently?

busbey · 2019-09-06T19:00:15Z

voltdb/src/main/java/com/yahoo/ycsb/db/voltdb/VoltClient4.java

+
+    int ratelimit = strLimit != null ? Integer.parseInt(strLimit) : Integer.MAX_VALUE;
+    try {
+      mclient = ConnectionHelper.createConnection(Thread.currentThread().getId(), servers, user, password, ratelimit);


if clientId isn't needed anymore, could it get removed? this call here is still not guaranteed to pass a unique long for each DB instance, since a thread could get reused.

busbey · 2019-09-06T19:05:33Z

voltdb/src/test/java/com/yahoo/ycsb/db/voltdb/test/VoltDBClientTest.java

+  private static boolean haveDb = false;
+
+  @BeforeClass
+  public static void setup() {


you should be able to do a single Assume.assumeTrue(haveDb); at the end of this setup method instead of doing one on each test.

I tried this and got:

Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.439 sec <<< FAILURE! - in com.yahoo.ycsb.db.voltdb.test.VoltDBClientTest
com.yahoo.ycsb.db.voltdb.test.VoltDBClientTest Time elapsed: 0.439 sec <<< ERROR!
org.junit.AssumptionViolatedException: got: , expected: is
at org.junit.Assume.assumeThat(Assume.java:95)
at org.junit.Assume.assumeTrue(Assume.java:41)
at com.yahoo.ycsb.db.voltdb.test.VoltDBClientTest.setup(VoltDBClientTest.java:100)

com.yahoo.ycsb.db.voltdb.test.VoltDBClientTest Time elapsed: 0.439 sec <<< ERROR!
org.junit.AssumptionViolatedException: got: , expected: is
at org.junit.Assume.assumeThat(Assume.java:95)
at org.junit.Assume.assumeTrue(Assume.java:41)
at com.yahoo.ycsb.db.voltdb.test.VoltDBClientTest.teardown(VoltDBClientTest.java:124)

I've put it back the way it was - do you know how to get it to work with a single 'Assume' or shall we leave it as is?

srmadscience · 2019-09-17T09:37:22Z

Other than the "Assume.assumeTrue(haveDb)" niggle everything appear to be OK now...

busbey · 2019-09-17T11:25:46Z

Yep, I agree. Thanks for keeping at this David!

srmadscience added 2 commits July 1, 2019 18:51

[voltdb] Release Candidate

89e848f

[voltdb] JavadocStyle: First sentence should end with a period.

9200099

srmadscience changed the title ~~Db voltdb~~ [db voltdb] Jul 2, 2019

srmadscience changed the title ~~[db voltdb]~~ [db voltdb] Add VoltDB client Jul 2, 2019

busbey requested changes Jul 3, 2019

View reviewed changes

srmadscience added 4 commits July 6, 2019 09:43

[db voltdb] First pass at resolves issues raised around brianfrankcoo…

0a534e8

…per#1319

[db voltdb] Fix procedure class name issue

3b375e8

[voltdb] Fixes for pull request #feedback

3eac920

[db voltdb] Fixes for pull request brianfrankcooper#1319 feedback

74f8bd2

srmadscience added 2 commits July 24, 2019 12:33

[voltdb] changed default value for threads in voltdb.properties to 1 …

cf9fe36

…in README

[voltdb] fixed bin diretory SNAFU

363f724

srmadscience mentioned this pull request Jul 25, 2019

Probably a stupid question re workflow... #1329

Closed

busbey requested changes Aug 20, 2019

View reviewed changes

srmadscience added 10 commits September 3, 2019 09:46

[voltdb] fixed bindings

1424ea4

[voltdb] fixed jdbc README.md

da873b3

Merge branch 'db_voltdb' of https://github.com/srmadscience/YCSB into…

0204c7c

… db_voltdb

[voltdb] fixed sortedvolttable package name

e8ddb53

[voltdb] added SLF4J + Log4j 2

0ebc1ec

[voltdb] Reverted cleint & server

52fbced

[voltdb] checkstyle violations

05feedb

[voltdb] checkstyle violations

91e529a

[voltdb] checkstyle violations

d120449

Fixed bin directory

84e59b7

srmadscience added 4 commits September 6, 2019 09:40

[voltdb] Rewrote client handling, changed logic for creating DDL

209df09

[voltdb] checkstyle fixes

870b322

[voltdb] Moved to MIT compliant licences for VoltDB libs

f6eb76a

[voltdb] Fixed %s formatting issue in log message

7a5b2e6

busbey requested changes Sep 6, 2019

View reviewed changes

srmadscience added 5 commits September 6, 2019 13:59

[voltdb] Updated pom.xml to 9.1

944ebca

[voltdb] Various code changes

69b199f

[voltdb] switch to singleton holder idiom.

8c61359

[voltdb] change voltdb lib to runtime dependency

b2b866f

[voltdb] change voltdb lib to default compile dependency

f9e5b11

[voltdb] change voltdb lib to provided dependency

b84606d

[voltdb] now uses Assume.assumeTrue(haveDb)

4df5c83

busbey requested changes Sep 6, 2019

View reviewed changes

srmadscience added 6 commits September 7, 2019 09:30

[voltdb] remove clientId

bbb968b

[voltdb] Re-arranged calls to Assume.assumeTrue(haveDb);

06a9656

[voltdb] Addded call to Assume.assumeTrue(haveDb) to teardown

4be8943

[voltdb] Put old Assume.assumeTrue(haveDb)'s back

a9a82b0

[voltdb] Remove Assume.assumeTrue from setup and teardown methods

ff5ba0f

[voltdb] Change all VoltDB versions to 9.1.1

fffe7e7

busbey merged commit cc165f2 into brianfrankcooper:master Sep 17, 2019

busbey mentioned this pull request Sep 21, 2019

Release 0.17.0 #1355

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[db voltdb] Add VoltDB client #1319

[db voltdb] Add VoltDB client #1319

srmadscience commented Jul 2, 2019

busbey left a comment

srmadscience commented Jul 3, 2019 via email

srmadscience commented Jul 16, 2019 •

edited

Loading

busbey commented Aug 20, 2019

srmadscience commented Aug 20, 2019 via email

srmadscience commented Aug 21, 2019

srmadscience commented Aug 28, 2019

busbey commented Aug 28, 2019

srmadscience commented Sep 6, 2019

busbey left a comment

srmadscience commented Sep 6, 2019

busbey commented Sep 6, 2019

srmadscience commented Sep 6, 2019

srmadscience commented Sep 6, 2019

busbey Sep 6, 2019

busbey Sep 6, 2019

busbey Sep 6, 2019

srmadscience Sep 7, 2019

srmadscience commented Sep 17, 2019

busbey commented Sep 17, 2019

[db voltdb] Add VoltDB client #1319

[db voltdb] Add VoltDB client #1319

Conversation

srmadscience commented Jul 2, 2019

busbey left a comment

Choose a reason for hiding this comment

srmadscience commented Jul 3, 2019 via email

srmadscience commented Jul 16, 2019 • edited Loading

busbey commented Aug 20, 2019

srmadscience commented Aug 20, 2019 via email

srmadscience commented Aug 21, 2019

srmadscience commented Aug 28, 2019

busbey commented Aug 28, 2019

srmadscience commented Sep 6, 2019

busbey left a comment

Choose a reason for hiding this comment

srmadscience commented Sep 6, 2019

busbey commented Sep 6, 2019

srmadscience commented Sep 6, 2019

srmadscience commented Sep 6, 2019

busbey Sep 6, 2019

Choose a reason for hiding this comment

busbey Sep 6, 2019

Choose a reason for hiding this comment

busbey Sep 6, 2019

Choose a reason for hiding this comment

srmadscience Sep 7, 2019

Choose a reason for hiding this comment

srmadscience commented Sep 17, 2019

busbey commented Sep 17, 2019

srmadscience commented Jul 16, 2019 •

edited

Loading