Remove hard-coded property key strings in favour of string constants #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
restarted CI build. |
busbey
added a commit
that referenced
this pull request
May 21, 2015
Remove hard-coded property key strings in favour of string constants
|
Thanks for the improvement! |
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
…roperties Remove hard-coded property key strings in favour of string constants
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
…roperties Remove hard-coded property key strings in favour of string constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the YCSB core code contained some hard-coded property keys, with others defined as constants. This pull request removes the remaining hard-coded strings in favour of string constants defined in
core/src/main/java/com/yahoo/ycsb/Client.javaandcore/src/main/java/com/yahoo/ycsb/measurements/Measurements.java.