Clean up bin/ycsb. #276
Clean up bin/ycsb. #276
Conversation
|
nit: could you include a prefix in the commit message's first line for what got altered. We don't have a good list of these yet, but something like [deployment], [packaging], or [shellcode] would all be great. (this is one of the things I want to make sure we cover in the contribution guide, but I recognize without that document for guidance this will be inconsistent for some time.) |
|
Sure - added |
| "-target n" : "Target ops/sec (default: unthrottled)", | ||
| "-threads n" : "Number of client threads (default: 1)", | ||
| "-cp path" : "Additional Java classpath entries", | ||
| "--jvm-args args" : "Additional arguments to the JVM", |
There was a problem hiding this comment.
above we use single dash for long-form arguments, and here we're using gnu style '--'. I don't have a strong preference one way or the other, but we should be consistent.
There was a problem hiding this comment.
I used -cp since it gets passed directly to java. Seems like single dash long form is more consistent - I'll change --jvm-args to -jvm-args.
|
yeah [scripts] is fine by me. |
* Use argparse for argument parsing. * Add a '-jvm-args' flag, to pass arbirary options to java. * Exit with the return code from java. Requires Python 2.7.
|
I tested this against HBase: worked for me. |
|
👍 presuming Travis comes back clean. |
Clean up bin/ycsb.
Clean up bin/ycsb.
Requires Python 2.7.