[Core] Add retry for insertion logic to make the load process more robust #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guys, would you have time to take a look at this soon? I will be offline in about 5 calendar days, would like to wrap this up before then if possible. Thanks! |
| @@ -1,11 +1,11 @@ | |||
| /** | |||
| * Copyright (c) 2010 Yahoo! Inc. All rights reserved. | |||
| * | |||
| * Copyright (c) 2010 Yahoo! Inc. All rights reserved. | |||
There was a problem hiding this comment.
note to other reviewers, this copyright header is wrong but the problem is covered by #313.
|
overall looks straight forward. I'll check back again later this evening. |
- Remove trailing whitespaces, - Break longlines to below 120 chars - Right indentation. This is to prepare for the next commit that will add retry logic to insert to make the load process more fault tolerant.
…bust The default behavior is NO RETRY, which is the current behavior. But optionally user can enable retry if they are working with a DB backend that is better tolerated by allowing a few retries.
Prefix the retry limit property name with core_workload. [core] Incorporate CR Feedback Prefix the retry limit property with "core_workload".
|
Pushed the change that incorporates CR feedback, rebased, and squashed. PTAL. Thanks! |
busbey
added a commit
that referenced
this pull request
Dec 12, 2015
[Core] Add retry for insertion logic to make the load process more robust
|
Thanks for the contribution! |
|
Happy to contribute! Likewise, thank you for your code reviews, discussions, and contributions to the community here! |
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
…fixes [Core] Add retry for insertion logic to make the load process more robust
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
…fixes [Core] Add retry for insertion logic to make the load process more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior is NO RETRY, which is the current behavior.
But optionally user can enable retry if they are working with a DB backend that is better tolerated by allowing a few retries.
This is for issue #508
Notes for reviewers: The first commit is purely formatting change only, the second commit is the change.