Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[accumulo] don't run Accumulo tests on windows build. #626

Merged
merged 1 commit into from
Feb 22, 2016
Merged

[accumulo] don't run Accumulo tests on windows build. #626

merged 1 commit into from
Feb 22, 2016

Conversation

busbey
Copy link
Collaborator

@busbey busbey commented Feb 22, 2016

The Accumulo tests don't properly initialize their mini cluster on windows,
so skip the tests entirely in that environment.

closes #617

@busbey
[accumulo] don't run Accumulo tests on windows build.
110dbf4 
The Accumulo tests don't properly initialize their mini cluster on windows,
so skip the tests entirely in that environment.

closes brianfrankcooper#617
@busbey busbey mentioned this pull request Feb 22, 2016
Closed
@risdenk
Copy link
Collaborator

risdenk commented Feb 22, 2016

👍

risdenk added a commit that referenced this pull request Feb 22, 2016
@risdenk
Merge pull request #626 from busbey/accumulo-windows
71dfb5d 
[accumulo] don't run Accumulo tests on windows build.
@risdenk risdenk merged commit 71dfb5d into brianfrankcooper:master Feb 22, 2016
@risdenk risdenk mentioned this pull request Feb 22, 2016
Merged
@risdenk
Copy link
Collaborator

risdenk commented Feb 22, 2016

@busbey Reverting this since travis never ran on it? I went to check the tests on my Mac and ran into the following:

Tests in error:
  com.yahoo.ycsb.db.accumulo.AccumuloTest: Zookeeper did not start within 20 seconds. Check the logs in /var/folders/nk/ny7z1tvd543gfh5jh6zs_0n40000gn/T/junit5820234677345844263/accumulo/logs for errors.  Last exception: java.net.ConnectException: Connection refused

@risdenk
Copy link
Collaborator

risdenk commented Feb 22, 2016

@busbey - getting same issue after reverting this PR.

@risdenk
Copy link
Collaborator

risdenk commented Feb 22, 2016

this wasn't an issue when I created the RC so not sure what is going on here.

@risdenk
Copy link
Collaborator

risdenk commented Feb 22, 2016

@busbey the error was an issue with my environment. Can you reopen this PR so I can merge it again?

@busbey
Copy link
Collaborator Author

busbey commented Feb 22, 2016

I don't see a way to reopen. I can either open a new PR with the same changes or one to revert the reversion. Have a preference on which will be less confusing?

@busbey
Copy link
Collaborator Author

busbey commented Feb 22, 2016

(still concerned that no travis run happened, no obvious reason why though.)

@risdenk
Copy link
Collaborator

risdenk commented Feb 22, 2016

Open a new PR with the same changes is probably best. Sorry for the inconvenience. :/

I went to travis after and noticed that it did run the test but looks like it never updated the PR.

@busbey
Copy link
Collaborator Author

busbey commented Feb 22, 2016

PR up as #628. travis says it's going now.

@cmatser cmatser mentioned this pull request Apr 2, 2016
Closed
jaricftw pushed a commit to jaricftw/YCSB that referenced this pull request Jul 19, 2016
@risdenk
Merge pull request brianfrankcooper#626 from busbey/accumulo-windows
00d243e 
[accumulo] don't run Accumulo tests on windows build.
jaricftw pushed a commit to jaricftw/YCSB that referenced this pull request Jul 19, 2016
@risdenk
Merge pull request brianfrankcooper#626 from busbey/accumulo-windows
5000ccc 
[accumulo] don't run Accumulo tests on windows build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accumulo tests fail on windows
2 participants
@busbey @risdenk