[core] Add byte to double and long conversion methods to Utils. #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,124 @@ | |||
| /** | |||
| * Copyright (c) 2016 Yahoo! Inc. All rights reserved. | |||
There was a problem hiding this comment.
Instead of Yahoo! Inc. This should be Copyright (c) 2016 YCSB contributors. All rights reserved.
|
The copyright for the top of |
|
Roger that, tweaked the copyrights. |
|
Please update the commit message to start with the impacted module, e.g. "[core] ..." |
| * {@link #doubleToBytes}. | ||
| * @param bytes The byte array to parse, at least 8 bytes. | ||
| * @return A double value read from the byte array. | ||
| * @throws IllegalArgumentException if the byte array is not 8 bytes wide. |
There was a problem hiding this comment.
This description should match the actual check.
These will be used for brianfrankcooper#653 to write timestamps and numeric values to the ByteIterator maps.
busbey
added a commit
that referenced
this pull request
Mar 21, 2016
[core] Add byte to double and long conversion methods to Utils.
|
thanks for the improvement! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be used for #653 to write timestamps and numeric values
to the ByteIterator maps.