Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cassandra2-cql driver to only run tests on jdk8 #669

Merged
merged 4 commits into from
Mar 30, 2016

Conversation

busbey
Copy link
Collaborator

@busbey busbey commented Mar 25, 2016

update the work in #614 so that maven skips tests under jdk7 and uses a profile to turn them on under jdk8.

@risdenk
Copy link
Collaborator

risdenk commented Mar 25, 2016

Looks good to me. Didn't get to test it on JDK 8 though.

@busbey
Copy link
Collaborator Author

busbey commented Mar 25, 2016

I could add the travis-ci change to test jdk8 now, if it would help?

@risdenk
Copy link
Collaborator

risdenk commented Mar 30, 2016

👍 sorry @busbey took me a few days to get back to this.

@busbey
Copy link
Collaborator Author

busbey commented Mar 30, 2016

No worries. Is the thumbs up for merging as-is or for adding the travis-ci change?

@risdenk
Copy link
Collaborator

risdenk commented Mar 30, 2016

merge. I think the travis ci change should be separate.

@busbey busbey merged commit 6d2f903 into brianfrankcooper:master Mar 30, 2016
@cmatser cmatser mentioned this pull request Apr 2, 2016
@risdenk
Copy link
Collaborator

risdenk commented Apr 5, 2016

Just as a note: this prints a really "scary" message about sigar on Mac when trying to test with JDK 8. The warning doesn't cause any issues and the tests pass just fine. An example of the message is here:

no libsigar-amd64-linux.so in java.library.path
org.hyperic.sigar.SigarException: no libsigar-amd64-linux.so in java.library.path
        at org.hyperic.sigar.Sigar.loadLibrary(Sigar.java:172)
        at org.hyperic.sigar.Sigar.<clinit>(Sigar.java:100)
        at org.apache.cassandra.utils.SigarLibrary.<init>(SigarLibrary.java:47)
        at org.apache.cassandra.utils.SigarLibrary.<clinit>(SigarLibrary.java:28)
        at org.apache.cassandra.service.StartupChecks$6.execute(StartupChecks.java:197)
        at org.apache.cassandra.service.StartupChecks.verify(StartupChecks.java:106)
        at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:169)
        at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:551)
        at org.cassandraunit.utils.EmbeddedCassandraServerHelper$1.run(EmbeddedCassandraServerHelper.java:125)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants