Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README and sample config file for jdbc #872

Merged
merged 2 commits into from
Nov 15, 2016
Merged

Update README and sample config file for jdbc #872

merged 2 commits into from
Nov 15, 2016

Conversation

gitanuj
Copy link
Contributor

@gitanuj gitanuj commented Nov 8, 2016

I was going through jdbc bindings (for integration with cockroachdb) and found some inconsistencies:

  1. The README mentions that a workload file can be supplied to com.yahoo.ycsb.db.JdbcDBCreateTable. However there's nothing in the class which makes use of it. I assume it's unnecessary.
  2. Update the property key for jdbc driver from "jdbc.driver" to "db.driver" according to JdbcDBClient.DRIVER_CLASS.

@risdenk
Copy link
Collaborator

risdenk commented Nov 9, 2016

@gitanuj Thanks for the PR! I won't have a chance to look at this till Friday but wanted you to know it was seen.

@risdenk risdenk self-assigned this Nov 9, 2016
risdenk
risdenk approved these changes Nov 15, 2016
View reviewed changes
Copy link
Collaborator

@risdenk risdenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gitanuj changes look good to me.

@risdenk risdenk merged commit 1b8ebe4 into brianfrankcooper:master Nov 15, 2016
@risdenk risdenk mentioned this pull request Nov 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risdenk risdenk risdenk approved these changes

Assignees

@risdenk risdenk

Labels
improvement jdbc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitanuj @risdenk