fix: validate encode input and ensure zero-filled Buffer #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeirionHughes
changed the title
MeirionHughes
commented
May 15, 2018
| @@ -10,7 +10,7 @@ export default function padString(input: string): string { | |||
| let position = stringLength; | |||
| let padLength = segmentLength - diff; | |||
| let paddedStringLength = stringLength + padLength; | |||
| let buffer = new Buffer(paddedStringLength); | |||
There was a problem hiding this comment.
depreciated since node 4. Warning in Node 10. likely unsupported in Node 11
|
Alternatively, drop node 4 support and add engine >=6 - |
MylesBorins
reviewed
May 15, 2018
There was a problem hiding this comment.
Closing #26 as a dupe
You are likely going to have to update lines 7 & 46 in test/base64url.test.js
I would also suggest adding 8 / 10 to the travis yaml
|
@brianloveswords dropping support for 0.10 and 0.12 is arguably semver-major. Node.js does have a history of landing Semver-Major changes as Semver-Minor for security updates |
MylesBorins
approved these changes
May 15, 2018
This was referenced Feb 11, 2019
This was referenced May 23, 2019
1 task
This was referenced Jul 16, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24
requires: node ^4