improve codegen #40
improve codegen #40
Conversation
brillout
force-pushed
the
dev
branch
10 times, most recently
from
4195a92
to
043e798
Compare
There was a problem hiding this comment.
It's a big improvement! I like that there is some information for the user what happened during shield() generation, even when it succeeded. Also good change that tsconfig.json is taken into account, that means shield() generation should work well with types defined outside of the *.telefunc.ts source files.
You have to explain sometime to me why you keep a list of projects.
| assertModuleScope('codegen/generateShield.ts') | ||
| const generatedShields: GeneratedShield[] = [] | ||
| const projects: Record<string, Project> = {} | ||
|
|
There was a problem hiding this comment.
Can these mutable (module scoped) 'global' variables be avoided?
There was a problem hiding this comment.
The lifetime of these global variables are during the build, e.g. during $ vite build. That's what we want: we want these variables to contain all information during the entire build.
The server runtime never loads code/generateShield.ts and these variables are not created at all.
| } | ||
| } | ||
|
|
||
| function formatGeneratedShields(generatedShields: GeneratedShield[], root: string) { |
There was a problem hiding this comment.
Might get a bit too long with many telefunctions
There was a problem hiding this comment.
I was thinking it's fine to print GenerateShield[]to the user after the build has finished, because that's what Vite does as well: upon$ vite build Vite shows all generated dist/ files. So it aligns well with Vite. But yes I agree that for other stacks like Next.js we may not want to do that.
We can also just print something like shield() generated for 14 telefunctions. Maybe with some kind of threshold e.g. if more than 7 then print a more compact log.
| return typeToShieldSrc | ||
| } | ||
|
|
||
| function findTsConfig(telefuncFilePath: string): string | null { |
There was a problem hiding this comment.
This will not work as intended when people use Telefunc with a project that uses configuration file inheritance.
There was a problem hiding this comment.
Maybe this is a limitation we can address in the documentation, or perhaps ts-morph has some tools that can bed used here.
There was a problem hiding this comment.
I'm probably missing something here, but the way I see it is that it should work because of the following.
From https://www.typescriptlang.org/docs/handbook/tsconfig-json.html:
The presence of a tsconfig.json file in a directory indicates that the directory is the root of a TypeScript project.
So AFAICT one tsconfig.json = one TS project. With the only exception that a TS project may not have any tsconfig.json (this PR also handles this case).
In case the user has multiple |
Co-authored-by: Bart Louwers <bart@emeel.net>
No description provided.