Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with report generation across platforms #302

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

sjfleming
Copy link
Member

@sjfleming sjfleming commented Oct 31, 2023

  • make report generation platform-agnostic
  • attempt to fix bugs with encoding of HTML (specify UTF-8 encoding, make it fault tolerant)
  • fix a failing test due to IndexConverter.get_m_indices receiving torch tensors during posterior generation

Closes #265
Closes #273
Closes #278
Closes #287

Fix failing integration test during posterior generation
(unclear why it is suddenly failing)
@sjfleming sjfleming merged commit 084194b into dev Oct 31, 2023
4 checks passed
sjfleming added a commit that referenced this pull request Oct 31, 2023
* Add WDL input to set number of retries. (#247)

* Move hash computation so that it is recomputed on retry, and now-invalid checkpoint is not loaded. (#258)

* Bug fix for WDL using MTX input (#246)

* Memory-efficient posterior generation (#263)

* Fix posterior and estimator integer overflow bugs on Windows (#259)

* Move from setup.py to pyproject.toml (#240)

* Fix bugs with report generation across platforms (#302)

---------

Co-authored-by: kshakir <github@kshakir.org>
Co-authored-by: alecw <alecw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant