-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search and site suggestions does not work on duckduckgo #19
Comments
Does it work with Google? The URLs are specified: https://github.com/bromite/bromite/blob/master/patches/privacy/add-duckduckgo.patch So it should work, unless some other patch disables them |
Yes, suggestions work fine for both Google and Bing. Hmm, not sure why ddg is the exception. I tried this in Chrome, and it works fine. I added the engine by going to duckduckgo.com and using their Add ddg to Chrome button. I can't do the same thing for bromite since the entry is already there by default. Is there an easy way to see the suggestion URL configuration for and installed version of Bromite? |
@csagan5, out anyone else, are you able to reproduce this? |
I figured out why. The URL specified there is incorrect (it comes from an original patch from Inox patchset if I remember correctly) and DuckDuckGo does not support suggestion URLs. See https://duck.co/ideas/idea/547/query-suggestions-in-json-format-would-be-usuable That is a question of ~5.5 years ago; I suggest using StartPage which is more transparent than DuckDuckGo, but it also does not have suggestions. |
I do prefer startpage, but have not been using it because of the lack of suggestions support. Is it easy at all for Bromite users to add the Google suggestions URL to the startpage search? In Chrome, duckduckgo.com can be added using their Add ddg to Chrome button, which sports suggestions. |
Startpage does not offer such feature...I suggest opening a discussion in their forums maybe? Regarding DDG: can you open the development console and check what URL is being used for the suggestions printed in address bar? I have seen that they have suggestions on their home page, not from chrome address bar. |
Suggestions on startpage works fine on the Brave browser. I'm guessing the suggestions URL is separate from the search engine. In other words, they use Google for suggestions even on the startpage search. |
@JoeTvx I went to check in their source code: https://github.com/brave/browser-android-tabs/blob/master/components/search_engines/prepopulated_engines.json#L122 So now I will try using the same definition for DDG, it should work. Thanks for reporting an example of another Chromium-based browser (Brave) where it works. By the way, I have seen that one can just visit a search engine page and then it is possible to add that browser. This feature must have been added recently in Chromium. |
Awesome, thank you. If you could also pick up the startpage definitions from Brave, that would be very helpful too since suggestions work on that as well. Yes, I noticed the feature you're talking about as well, and would be very glad if it did indeed come from Chromium. OT, but thank you so much for Bromite! The world sorely needs a modern open source browser with no strings attached! |
@JoeTvx yes it seems that they found some undocumented API, I will use their definition for StartPage as well. The next release is building so should be available in a day or so. |
DDG suggestions work now, thank you! Startpage suggestions don't work though. Nor can I add custom engines. Are there plans to include the latter feature? |
@JoeTvx adding custom engines is a feature of Chrome/Chromium, not Bromite. it works so that after visiting a search engine, you can go to the search engines selection in settings and pick it up |
@csagan5, right, I understand, and hence my question. I see that feature in Chromium but not in the latest version of Bromite, and was wondering if you knew why. |
@csagan5, do startpage suggestions work for you? |
@JoeTvx yes. you have to enable site suggestions because they are disabled by default in Bromite |
I do have site suggestions enabled. It works fine for me in all other search engines except startpage. What gives? |
Anyone else seeing this with startpage? |
@csagan5, are you able to reproduce this? Should I open a separate ticket for this? Thanks. |
…and AP9 Premium Chromium App Merge in AP/chromiumpatches from AP9-3128 to master * commit 'af4b2e1935195bde4ea152969fa6a928a215a6ed': AP9-3128 Implement telemetry events for AP9 and AP9 Premium Chromium App
Even when I enable this in Settings. Is this feature even supported by Bromite? If not, my apologies.
64.3278.0 on Android 8.0.0.
The text was updated successfully, but these errors were encountered: