pybamm-team#1506 fix tests

brosaplanella · Jul 27, 2021 · c72ff9d · c72ff9d
1 parent 1a54286
commit c72ff9d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/tests/unit/test_parameters/test_lead_acid_parameters.py b/tests/unit/test_parameters/test_lead_acid_parameters.py
@@ -34,8 +34,12 @@ def test_parameters_defaults_lead_acid(self):
         self.assertLess(param_eval["C_e"], param_eval["C_rate"])
 
         # Dimensionless electrode conductivities should be large
-        self.assertGreater(param_eval["sigma_n"], 10)
-        self.assertGreater(param_eval["sigma_p"], 10)
+        self.assertGreater(
+            parameter_values.evaluate(parameters.sigma_n(parameters.T_ref)), 10
+        )
+        self.assertGreater(
+            parameter_values.evaluate(parameters.sigma_p(parameters.T_ref)), 10
+        )
         # Dimensionless double-layer capacity should be small
         self.assertLess(param_eval["C_dl_n"], 1e-3)
         self.assertLess(param_eval["C_dl_p"], 1e-3)

diff --git a/tests/unit/test_parameters/test_lithium_ion_parameters.py b/tests/unit/test_parameters/test_lithium_ion_parameters.py
@@ -150,21 +150,25 @@ def test_lithium_ion(self):
 
         "electrode conductivities"
         # neg dimensional
-        np.testing.assert_almost_equal(values.evaluate(param.sigma_n_dim), 100, 3)
+        np.testing.assert_almost_equal(
+            values.evaluate(param.sigma_n_dimensional(param.T_ref)), 100, 3
+        )
 
         # neg dimensionless (old sigma_n / old_Lambda ) (this is different to values
         # in paper so check again, it is close enough though for now)
         np.testing.assert_almost_equal(
-            values.evaluate(param.sigma_n * c_rate), 475.7, 1
+            values.evaluate(param.sigma_n(param.T_ref) * c_rate), 475.7, 1
         )
 
         # neg dimensional
-        np.testing.assert_almost_equal(values.evaluate(param.sigma_p_dim), 10, 3)
+        np.testing.assert_almost_equal(
+            values.evaluate(param.sigma_p_dimensional(param.T_ref)), 10, 3
+        )
 
         # neg dimensionless (old sigma_n / old_Lambda ) (this is different to values in
         # paper so check again, it is close enough for now though)
         np.testing.assert_almost_equal(
-            values.evaluate(param.sigma_p * c_rate), 47.57, 1
+            values.evaluate(param.sigma_p(param.T_ref) * c_rate), 47.57, 1
         )
 
     def test_thermal_parameters(self):