-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unicode paths on windows #40
Comments
master has in ignored test now. Unicode paths don't work on windows yet, but also binaryen just prints to console and exits when it fails to read a file:
|
My suspicion is that binaryen doesn't work with unicode paths on windows because it doesn't have any explicit wide char support. I am investigating whether the wasm-opt CLI does somehow work with unicode paths - maybe there's some compatibility hack inside the c++ library, or some alternate way to encode unicode paths on windows that doesn't use wide chars. |
I have made progress on this in my binaryen unicode branch: https://github.com/brson/binaryen/tree/unicode It is able to build a wasm-opt that handles unicode paths on windows. Still have to convert all the other binaries, do some simplifications, write some tests, and figure out how to integrate it into this crate. |
This is fixed in binaryen now. Doesn't seem to be in 116, so I'll try to retest in 117. |
I'm not confident that the conversions are correct. We need some tests that take input and output files with extended-unicode paths, both tests of the api, and of the wasm-opt binary.
The text was updated successfully, but these errors were encountered: