Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm-opt-for-rust-m1.md #552

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Add wasm-opt-for-rust-m1.md #552

merged 1 commit into from
Aug 29, 2022

Conversation

brson
Copy link
Contributor

@brson brson commented Aug 25, 2022

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#1070

@brson
Copy link
Contributor Author

brson commented Aug 25, 2022

cc @cmichi @Robbepop @kripken wasm-opt-for-rust milestone 1

@brson brson force-pushed the wasm-opt-m1 branch 2 times, most recently from 127a107 to 2c59ba8 Compare August 25, 2022 22:26
@brson
Copy link
Contributor Author

brson commented Aug 25, 2022

Note that if somebody actually tries to install the binary for this "preview" version, they will need to specify the version explicitly, like cargo install wasm-opt --version 0.0.1-preview.3 --locked, as cargo will not select prerelease versions by default.

@lucasvanmol lucasvanmol self-assigned this Aug 26, 2022
@lucasvanmol
Copy link
Contributor

Thank you for the excellent delivery @brson! I’ve accepted it, evaluation here.

Regarding this comment in the delivery document:

As of now we believe that wasm-opt's fuzzing capabilities are not important for our use cases, and intend to not include them in the API. Feedback welcome.

That’s totally fine. If you wish you can submit an amendment to your application so that we are aware of this for the next milestone evaluation.

Finally, I'll notify the finances team to pay out your invoice; please allow for up to two weeks for processing.

@lucasvanmol lucasvanmol merged commit 7f04063 into w3f:master Aug 29, 2022
@github-actions
Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Note that it must only be used within the context of the delivered work, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant.

Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. In case you haven't done so yet, you may also reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution and good luck with the remaining milestones, if any! As usual, please let us know if you run into any delays by leaving a comment on the application PR, or directly submitting an amendment.

@brson
Copy link
Contributor Author

brson commented Aug 29, 2022

Thanks for the evaluation @lucasvanmol and for running tarpaulin on it. I filed an issue (brson/wasm-opt-rs#59) to look into it. It's not surprising that a tool that exercises the program in new ways would find a segfault - particularly in the low level bindings there are code paths that binaryen doesn't expect and will fail hard. I'll figure out how to get taurpaulin working, and consider running at least the high-level apis through additional analysis tools to see if they uncover any more obvious segfaults.

@lucasvanmol
Copy link
Contributor

I'll figure out how to get taurpaulin working, and consider running at least the high-level apis through additional analysis tools to see if they uncover any more obvious segfaults.

Thanks for that! I mentioned it because I thought it might be of interest to the project, but note that it's not a requirement for us in terms of milestone delivery - you're of course free to look into it on your own volition.

@cmichi
Copy link

cmichi commented Aug 31, 2022

It's great to see this going well, looking forward to M2 😊!

Non-ascii paths on Windows don't work.

Nice to see that you are thinking about issues like this.

@RouvenP
Copy link

RouvenP commented Sep 2, 2022

hi @brson we transferred the payment today.

@brson
Copy link
Contributor Author

brson commented Sep 2, 2022

@RouvenP I have received the payment. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants