strum 0.25 #162
Open
strum 0.25 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does duplicate the syn dependency, unfortunately (v1 and v2). While there may accordingly be a desired to not merge this, as syn is presumably a heavier depend than strum, the only way the ecosystem will move forward is if eventually people move to syn v2.
|
It looks like this fails the build on our minimum Rust version 1.48: https://github.com/brson/wasm-opt-rs/actions/runs/7015422941/job/19305682921?pr=162 Seems that syn 2.0 doesn't support such an old compiler. |
|
Thanks for the context. That's unfortunate. While I'm fine closing this, mind if I ask why a version of 1.48 was chosen and considerations you'd make when discussing increasing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does duplicate the syn dependency, unfortunately (v1 and v2). While there may accordingly be a desired to not merge this, as syn is presumably a heavier depend than strum, the only way the ecosystem will move forward is if eventually people move to syn v2.