Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/adding if exists to drop command #19

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Feature/adding if exists to drop command #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80ce076
adding if exists to drop command
bruno-szdl Jun 27, 2024
7c6be23
fixing drop command syntax
bruno-szdl Jun 27, 2024
7e31b0b
making sha part of the schema id again
bruno-szdl Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:

- name: Get Schema ID
id: schema_id
run: echo "SCHEMA_ID=${{ github.event.pull_request.number }}" >> $GITHUB_ENV
run: echo "SCHEMA_ID=${{ github.event.pull_request.number }}__${{ github.sha }}" >> $GITHUB_ENV

- name: Run dbt debug
run: |
Expand Down
2 changes: 1 addition & 1 deletion macros/drop_pr_staging_schemas.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
)

select
'drop schema '||schema_name||';' as drop_command
'drop schema if exists '||schema_name||';' as drop_command
from pr_staging_schemas
{% endset %}

Expand Down
1 change: 0 additions & 1 deletion models/jaffle-shop/marts/fact_orders.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ with
, stg_orders.status
, payment_methods_agg.payment_methods
, payment_methods_agg.amount
, null as dummy
from stg_orders
left join payment_methods_agg
on stg_orders.id = payment_methods_agg.order_id
Expand Down
Loading