Skip to content
This repository has been archived by the owner on Jul 7, 2024. It is now read-only.

Add rand initialization for Chain #17

Merged
merged 13 commits into from
Feb 26, 2024
Merged

Add rand initialization for Chain #17

merged 13 commits into from
Feb 26, 2024

Conversation

jofrevalles
Copy link
Member

@jofrevalles jofrevalles commented Feb 26, 2024

Summary

This PR addresses #12 by adding the rand function for Chain types. For now, we have implemented it for Chain(Open, State) and Chain(Open, Operator).

@mofeing, the only thing missing now is the code in here. Do you think this is necessary?

@jofrevalles jofrevalles marked this pull request as draft February 26, 2024 08:44
@jofrevalles jofrevalles marked this pull request as ready for review February 26, 2024 09:13
Copy link
Member

@mofeing mofeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even sure that code is right, so I'm ok with not including the initialization for periodic MPS/MPO. We have to check that.

src/Ansatz/Chain.jl Outdated Show resolved Hide resolved
src/Ansatz/Chain.jl Outdated Show resolved Hide resolved
test/Ansatz/Chain_test.jl Outdated Show resolved Hide resolved
@mofeing mofeing linked an issue Feb 26, 2024 that may be closed by this pull request
@mofeing mofeing merged commit 161e4e2 into master Feb 26, 2024
1 of 3 checks passed
@mofeing mofeing deleted the feature/rand-init branch February 26, 2024 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rand unitary initialization of Chain
2 participants