Skip to content
This repository has been archived by the owner on Jul 7, 2024. It is now read-only.

Implement Chain normalization by mixed canonization #28

Merged
merged 11 commits into from
Mar 14, 2024

Conversation

Todorbsc
Copy link
Contributor

Closes #18

src/Ansatz/Chain.jl Outdated Show resolved Hide resolved
Copy link
Member

@jofrevalles jofrevalles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @mofeing comments, and it is a good idea to make that these kinds of functions work in-place. Also, the idea of normalizing in this manner is to take the Tensor that is not in either left nor right canonical form (the one in centersite), get its norm (since it is the one that contains the weights), and normalize by this value the entire Chain.

@Todorbsc
Copy link
Contributor Author

Check the changes. I am not sure if I have to do something else other than normalizing the centersite tensor. Doing it this way, the complete Chain is normalized because the weights are concentrated in the centersite tensor. Let me know :)

src/Ansatz/Chain.jl Outdated Show resolved Hide resolved
test/Ansatz/Chain_test.jl Outdated Show resolved Hide resolved
@mofeing
Copy link
Member

mofeing commented Mar 13, 2024

You're having a format problem. Please install JuliaFormatter and run format(".") on the project directory.

test/Ansatz/Chain_test.jl Outdated Show resolved Hide resolved
Todorbsc and others added 3 commits March 14, 2024 14:32
Co-authored-by: Jofre Vallès Muns <61060572+jofrevalles@users.noreply.github.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (11890f0) to head (31b8c29).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   75.00%   73.55%   -1.45%     
==========================================
  Files           8        8              
  Lines         436      450      +14     
==========================================
+ Hits          327      331       +4     
- Misses        109      119      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofeing mofeing merged commit c2c8e22 into master Mar 14, 2024
4 of 5 checks passed
@mofeing mofeing deleted the feature/issue#18_norm_by_canonization branch March 14, 2024 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement normalization by canonization for Chain
3 participants