Move dotimports testing lint to golangci

bufbuild · Feb 29, 2024 · 892d30e · 892d30e
1 parent 095e4e2
commit 892d30e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -64,6 +64,11 @@ issues:
     - path: (.+)_test\.go
       linters:
         - forcetypeassert
+    # Allow dot imports for testing.
+    - path: (.+)_test\.go
+      text: "^dot-imports: should not use dot imports"
+      linters:
+        - revive
     # Allow clocktest within tests
     - path: (.+)_test\.go
       text: "^use of `clocktest\\."

diff --git a/resolver/min_conns_test.go b/resolver/min_conns_test.go
@@ -18,7 +18,7 @@ import (
 	"context"
 	"testing"
 
-	. "github.com/bufbuild/httplb/resolver" //nolint:revive // use dot import for tests
+	. "github.com/bufbuild/httplb/resolver"
 	"github.com/stretchr/testify/assert"
 )
 

diff --git a/resolver/rendezvous_test.go b/resolver/rendezvous_test.go
@@ -19,7 +19,7 @@ import (
 	"io"
 	"testing"
 
-	. "github.com/bufbuild/httplb/resolver" //nolint:revive // use dot import for tests
+	. "github.com/bufbuild/httplb/resolver"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )