Proposal: Unify tests to _test packages and remove dot imports #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
export_test.go
pattern can be used to make all of our tests use the_test
pattern and ensure that the internal API surface we depend on in tests is explicitly defined. While not strictly necessary, this PR unifies tests using this strategy. Also, I ran go mod tidy and removed the one instance of dot imports (otherwise unused.)The only package where this is somewhat questionable IMO is
httplb
where the test-exported surface is a bit larger than ideal, but even so, I still think it's not a bad idea to keep it accounted for.