Upgrade to PG* v0.4.2 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htuch
reviewed
Sep 26, 2018
There was a problem hiding this comment.
Super awesome. @sesmith177 can you confirm this works on Windows? We should merge in any case before too long to unblock other work.
templates/cc/register.go
Outdated
| "quote": fns.quote, | ||
| "inType": fns.inType, | ||
| "inKey": fns.inKey, | ||
| "durLit": fns.durLit, |
|
@htuch looks good on Windows. We tested by running Also, after #96 was merged, it looks like we can simplify the powershell script here: https://github.com/lyft/protoc-gen-validate/blob/64fcb82c878efbfe3240e4f164490eefaf6b3c4b/windows/ci.ps1 to just wrap the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch upgrades the PG* dependency of PGV to v0.4.2, and rectifies the breaking API changes from that library (lyft/protoc-gen-star#28) as well as the adopted behaviors of
protoc-gen-go(#89).The majority of the modified files are changes in the
vendorfolder dependencies, followed by numerous changes to the BazelBUILDfiles resulting from running gazelle (and the fallout thereof).Templates were updated to use the new golang context from PG*'s to properly derive package and entity names & paths, properly accounting for the interplay of the go_package options and the protoc-gen-go plugin parameters.
Also in this patch, the kitchensink tests have been removed in favor of the test harnesses. This was done in this patch to minimize how much BUILD file work was needed to get this project buildable. Future work will follow this PR to improve the development workflow on this project to be less fragile.
(woof...massive change is massive)