-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dark mode #220
feat: dark mode #220
Conversation
BREAKING CHANGE: it could all go horribly wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look fine to me. Nice one!
Thanks for proposing & implementing this feature! I think it's a good addition. It's something we were thinking of possibly doing in So, I propose:
@danbull @dw-buildit : What say ye? *) Off the top of my head we could:
|
That would be my preference. I'm completely at sea as to how to actually implement it (in njks and json) though. |
So I've implented the dark mode for certain images using some (probably rather ropey) methods: Thoughts? |
Looks good to me - just watch out with the |
This is lookin' good to me. I'm happy for this PR to be un-drafted (is that the right term?) and merged. I see you've already prepped some associated changes on the website, so let's get this released as soon as we can. :-) |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: it could all go horribly wrong...
See https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme for more info.
Safari and FF67 support it at the moment with Chrome going to support it.
Things still needing done: