Skip to content

Commit

Permalink
Merge pull request #212 from KovalevAndrey/make-parent-property-prote…
Browse files Browse the repository at this point in the history
…cted

Make Node's parent property as public
  • Loading branch information
KovalevAndrey authored Oct 12, 2022
2 parents e7a4509 + 62436e2 commit 2909f7d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
## Pending changes

- [#197](https://github.com/bumble-tech/appyx/pull/197)**Breaking change**: `ParentNodeView` does not implement plugin anymore. Node instance is retrieved via LocalComposition. `AppyxParentViewTestRule` and `AbstractParentNodeView` have been removed.
- [#196](https://github.com/bumble-tech/appyx/pull/196)**Breaking change**: `InteropBuilder` now should be supplied with Appyx `IntegrationPointProvider` to attach it at the same time Appyx Node is created
- [#196](https://github.com/bumble-tech/appyx/pull/196)**Breaking change**: `InteropBuilder` now should be supplied with Appyx `IntegrationPointProvider` to attach it at the same time Appyx Node is created.
- [#185](https://github.com/bumble-tech/appyx/issues/185)**Breaking change**: `Activity` must implement `IntegrationPointProvider` and create `IntegrationPoint` manually. Weak references usage has been removed.
- [#173](https://github.com/bumble-tech/appyx/pull/173)**Breaking change**: `ActivityStarter` and `PermissionRequester` now exposes coroutine based API instead of `minimal.reactive`.
- [#200](https://github.com/bumble-tech/appyx/pull/200)**Breaking change**: Reordered the parameters for `ParentNode<NavTarget>.Child` and `fun <N : Node> NodeHost` to meet Compose guidelines.
- [#43](https://github.com/bumble-tech/appyx/pull/43)**Updated**: Jetpack Compose to 1.2.1 and kotlin to 1.7.10.
- [#168](https://github.com/bumble-tech/appyx/pull/168)**Updated**: Kotlin coroutines to 1.6.4.
- [#171](https://github.com/bumble-tech/appyx/pull/171)**Updated**: RIBs to 0.36.1.
- [#171](https://github.com/bumble-tech/appyx/pull/171)**Updated**: RIBs to 0.36.1.
- [#212](https://github.com/bumble-tech/appyx/pull/212)**Updated**: `Node` parent property is now public instead of private.
- [#174](https://github.com/bumble-tech/appyx/issues/174)**Fixed**: IntegrationPointExample does not work with "do not keep activities"
- [#180](https://github.com/bumble-tech/appyx/pull/180)**Added**: Ensure that super.onSaveInstanceState() was called to restore Node's state correctly

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ open class Node(
val isRoot: Boolean =
ancestryInfo == AncestryInfo.Root

private val parent: ParentNode<*>? =
val parent: ParentNode<*>? =
when (ancestryInfo) {
is AncestryInfo.Child -> ancestryInfo.anchor
is AncestryInfo.Root -> null
Expand Down

0 comments on commit 2909f7d

Please sign in to comment.