Suspend children #122
Merged
Suspend children #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Fixed
Show fixed
Hide fixed
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Show resolved
Hide resolved
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Outdated
Show resolved
Hide resolved
CherryPerry
force-pushed
the
suspend-children
branch
from
fc66b78
to
6d07b42
Compare
CherryPerry
force-pushed
the
suspend-children
branch
from
6d07b42
to
a549184
Compare
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Fixed
Show fixed
Hide fixed
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Fixed
Show fixed
Hide fixed
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Show resolved
Hide resolved
KovalevAndrey
approved these changes
Sep 7, 2022
core/src/main/kotlin/com/bumble/appyx/core/children/ChildEntry.kt
Outdated
Show resolved
Hide resolved
LachlanMcKee
reviewed
Sep 8, 2022
app/src/main/kotlin/com/bumble/appyx/app/node/onboarding/screen/StatefulNode2.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Outdated
Show resolved
Hide resolved
| is ChildEntry.Initialized -> | ||
| ChildEntry.Suspended( | ||
| key = key, | ||
| // TODO: Not able to get a scope from Compose here, providing fake one |
There was a problem hiding this comment.
ticket? What's the impact?
There was a problem hiding this comment.
Depends on a client usage of SaverScope. We are providing SaverScope right now do be able to use canSave in code, but honestly I do not see any value in it right now because we are supporting Android only. Also not sure if anybody ever used canSave except Compose internals.
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/bumble/appyx/core/children/ChildNodeCreationManager.kt
Show resolved
Hide resolved
LachlanMcKee
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple implementation with either keep all or suspend all.
KeepModeis introduced to specify keep logic of stashed (not visible) nodes. The value is passed directly intoParentNode.ChildEntryis refactored intoInitializedandSuspended.ChildNodeCreationManagercreates a snapshot of currently initialized and suspended nodes and compares it with the provided by nav model list. After calculating a diff, it applies required changes.Appyxclass moved to the root package and allows to setup default behaviour.Fixes #111
Fixes #120
Strategies
As a separate PR please, this one defines a foundation for further updates and allows faster feedback.
Check list
CHANGELOG.mdif required.