Converted customisations module from Android to Java #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LachlanMcKee
force-pushed
the
issue-47-customisations-java-module
branch
from
606ca49
to
5d5cb4d
Compare
LachlanMcKee
commented
Aug 1, 2022
| } | ||
| } | ||
| } else { | ||
| java { |
There was a problem hiding this comment.
I've verified this works by using publishToMavenLocal and inspecting the output
LachlanMcKee
force-pushed
the
issue-47-customisations-java-module
branch
from
5d5cb4d
to
983814f
Compare
CherryPerry
reviewed
Aug 2, 2022
CherryPerry
approved these changes
Aug 2, 2022
|
I hope it won't break transitive dependency in RIBs. |
LachlanMcKee
changed the title
LachlanMcKee
force-pushed
the
issue-47-customisations-java-module
branch
from
983814f
to
bd648c8
Compare
|
If this does cause an issue with RIBs, I will revert this. I am pretty confident it should not cause an issue however |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #47
Check list
CHANGELOG.mdif required.