Rollup of multiple PRs #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aling Newer Linux kernels do not unset `F_SEAL_SEAL` when `MFD_NOEXEC_SEAL` is supplied to `memfd_create()`[0]. Currently, `misc_memfd()` has a workaround for this peculiarity of the kernel, however, this workaround will break. Avoid the breakage by checking if the kernel added `F_SEAL_SEAL`, and only try to add it if it is not already present. Note that this kernel uAPI change does not affect dbus-broker's normal operations since it never attempts to create a memfd with `MFD_NOEXEC_SEAL` and without `MFD_ALLOW_SEALING`. Only the test suite would be broken on newer kernels without this change. [0]: https://lore.kernel.org/linux-mm/20240524033933.135049-1-jeffxu@google.com/ (break long comments to ensure 80ch limit) Signed-off-by: David Rheinsberg <david@readahead.eu>
We do not overload return types, but use explicit return pointers. Change the misc_memfd_get_seals() function to store seals in an explicit output argument. Signed-off-by: David Rheinsberg <david@readahead.eu>
Use the memfd helpers rather than directly invoking ioctls. This consolidates error handling in the helper. Signed-off-by: David Rheinsberg <david@readahead.eu>
Reported-by: Tomas Korbar <tkorbar@redhat.com> Signed-off-by: Jeffrey Bosboom <jbosboom@jeffreybosboom.com> Signed-off-by: David Rheinsberg <david@readahead.eu>
Use the latest checkout action to silence deprecation warnings. Signed-off-by: David Rheinsberg <david@readahead.eu>
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rollup of #366 and #369, including minor adjustments on top.