Multi column sort support #957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # source/Table/Table.jest.js # source/Table/Table.js
|
@bvaughn can u please review this version? I think it could be final one, but also welcome any suggestions whats can be improoved ... thx |
|
This has a bigger footprint than what I had in mind. I've created a counter-proposal (see PR #966) that shows the direction I tried to suggest when we last chatted about this. Please let me know your thoughts? |
|
I don't think I'm comfortable with the amount of duplication in prop-types and public methods between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original PR: #946