Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General refactor #21

Merged
merged 14 commits into from
Oct 20, 2022
Merged

General refactor #21

merged 14 commits into from
Oct 20, 2022

Conversation

kamilkrzyskow
Copy link
Contributor

This is a continuation of #20 therefore it has had its commits merged to avoid merge conflicts on second PR merge.
The rest of the commits could be squashed into 1 on merge.
It differs slightly compared to #19 as I didn't rename all of the functions and didn't change their order this time, so it should be a more manageable comparison.

@kamilkrzyskow
Copy link
Contributor Author

I had to force push again, to fix a previous commit message in case it's not being squashed.

Copy link
Collaborator

@wilhelmer wilhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mkdocs_minify_plugin/plugin.py Outdated Show resolved Hide resolved
@wilhelmer wilhelmer merged commit 39a2bc1 into byrnereese:master Oct 20, 2022
@wilhelmer
Copy link
Collaborator

Here we go, thank you!

@byrnereese Could you please publish v0.6.0 on PyPI? Unfortunately, I don't have the rights to do that.

@kamilkrzyskow
Copy link
Contributor Author

@wilhelmer
Thanks a lot for sticking with my not so optimal contribution. Great review process with finding all of those wording issues. 👍
As for PyPi, maybe adding some Github Action to handle that would be worthwhile in the long run.

@kamilkrzyskow kamilkrzyskow deleted the general-refactor branch October 21, 2022 10:47
@byrnereese
Copy link
Owner

@wilhelmer 0.6.0 has been deployed.

@wilhelmer
Copy link
Collaborator

@byrnereese I added a small bugfix for csscompressor, please deploy v0.6.1, thanks!

@byrnereese
Copy link
Owner

@wilhelmer done! Thank you!

@wilhelmer
Copy link
Collaborator

@byrnereese Another small bugfix, this time for jsmin. That's the last one for this year, I promise 😉 Please deploy v0.6.2, thanks!

@byrnereese
Copy link
Owner

@wilhelmer Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants