Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-smith: Implement support for generating GC instructions #1382

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jan 23, 2024

Found and fixed a bunch of bugs in the validator, encoder, and the generator itself. Since then, this has been fuzzing for about 18 hours without finding any new bugs.

Found and fixed a bunch of bugs in the validator, encoder, and the generator
itself. Since then, this has been fuzzing for about 18 hours without finding any
new bugs.
@fitzgen
Copy link
Member Author

fitzgen commented Jan 23, 2024

Okay, CI is green now.

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an impressive amount of work, thanks for going through all this as I'm sure it was a bit of a slog! Looking forward though to seeing how this gets used :)

crates/wasm-encoder/src/core/code.rs Show resolved Hide resolved
crates/wasmparser/src/validator/operators.rs Outdated Show resolved Hide resolved
crates/wasmparser/src/validator/operators.rs Outdated Show resolved Hide resolved
@fitzgen fitzgen enabled auto-merge (squash) January 24, 2024 17:41
@fitzgen
Copy link
Member Author

fitzgen commented Jan 24, 2024

Thanks for taking a look at this!

@fitzgen fitzgen merged commit 6470aa9 into bytecodealliance:main Jan 24, 2024
15 checks passed
@fitzgen fitzgen deleted the wasm-smith-gc-instructions branch January 24, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants