Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add APIKind to indicate std-json or sonic #673

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

lvan100
Copy link
Contributor

@lvan100 lvan100 commented Jul 16, 2024

We need to identify the current strategy, whether it is std-json or sonic, to implement a wrapper in our library. This wrapper will issue a warning if upgrading go.mod in a user's project downgrades from sonic to std-json. Our goal is to avoid this situation.

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2024

CLA assistant check
All committers have signed the CLA.

AsterDY
AsterDY previously approved these changes Jul 16, 2024
@AsterDY
Copy link
Collaborator

AsterDY commented Jul 16, 2024

cc @liuq19

api.go Show resolved Hide resolved
Copy link
Collaborator

@liuq19 liuq19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@liuq19 liuq19 merged commit 15dff36 into bytedance:main Jul 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants