Add option to sign tags. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Nov 30, 2017
| @@ -183,7 +185,7 @@ def add_path(cls, path): | |||
| pass | |||
|
|
|||
| @classmethod | |||
| def tag(cls, name, message): | |||
| def tag(cls, sign, name, message): | |||
There was a problem hiding this comment.
I think this should raise an error when sign is true that it's not supported.
ekohl
approved these changes
Dec 1, 2017
|
Bumping in case it got lost in your inbox @c4urself. Thanks! |
anthrotype
approved these changes
Dec 20, 2017
c4urself
approved these changes
Jan 2, 2018
|
Thanks @Californian! @c4urself do you want to do a release? I'm not sure I have permissions to do so. |
|
yep -- will try to get a release out this week. it would be nice if you also get the permissions, not sure what you need for that? |
|
My username on pypi is the same as my github. You should be able to log in on pypi, go to the bump2version package and select the roles tab. There you can add me as an owner or maintainer. https://pypi.python.org/pypi?:action=role_form&package_name=bump2version should be the direct URL. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added standard
.gitignorefiles for Python and vim.The test for Python 3.3 does not pass, but that appears to be because of an upstream issue checking out a required package.
A test to check that signatures are actually made has not been written, but it has been verified manually. I can add a test later, but it is a bit involved (it would require adding
gpgto theDockerfileand generating a signature in the test setup) and I do not currently have time for that.Closes GH-5