Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update fixpack to fixed version #6

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

pke
Copy link
Contributor

@pke pke commented Feb 18, 2020

@pke pke merged commit d9e5db9 into master Feb 18, 2020
@pke pke deleted the bugfix/fix-deep-extend-security-issue branch February 18, 2020 23:10
@niftylettuce
Copy link
Contributor

This isn't a security vulnerability...

@pke
Copy link
Contributor Author

pke commented Feb 18, 2020

I trusted GH and npm audit on this? Why you think its not?

@niftylettuce
Copy link
Contributor

because we aren't exposing this to a third party or for injection or anything remotely close to that

half of the security vulnerabilities published are a joke

@pke
Copy link
Contributor Author

pke commented Feb 18, 2020

Oh ok, so do you want to dismiss the security warnings on all cabinjs repos?
Should I revert this patch then? I just saw I also forgot to update the yarn.lock file anyway.

@niftylettuce
Copy link
Contributor

don't worry about it 😄 it's fine to leave as is

@pke
Copy link
Contributor Author

pke commented Feb 18, 2020

But update the yarn.lock file?

@niftylettuce
Copy link
Contributor

naw don't worry about it - next time I add more fields and have to republish I will update it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants