Delegating proxy instantiation to Javassist #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some tests as logged here: https://gist.github.com/garcia-jj/6726261 Objenesis and reflection have the same performance when create instances calling default constructor. |
garcia-jj
added a commit
that referenced
this pull request
Sep 27, 2013
Delegating proxy instantiation to Javassist
| } catch (Throwable throwable) { | ||
| throw new ProxyInvocationException(throwable); | ||
| } | ||
| class CustomHandler<T> |
There was a problem hiding this comment.
Didn't like this name... Since you've extracted a class, you should give a more meaningful name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CDI have restriction that all managed classes have a default constructor, we don't need objenesis anymore. The best benefit is performance, because Objenesis have your own instantiators cache, and Javassist have another cache for instrumented classes. If Javassist is responsible to create instances, we don't need both caches.
But I don't know if reflection is more faster then Objenesis.
Internally, Javassist uses Java reflection to create instances.