Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better linkTo syntax #143

Merged
merged 7 commits into from
Sep 30, 2013
Merged

Better linkTo syntax #143

merged 7 commits into from
Sep 30, 2013

Conversation

lucascs
Copy link
Member

@lucascs lucascs commented Sep 28, 2013

Using Javassist to generating a class to make possible the following syntax:

${linkTo[MyController].method}
${linkTo[MyController].method()}
${linkTo[MyController].method(someArg)}
${linkTo[MyController].method(someArg, otherArg)}

garcia-jj
garcia-jj reviewed Sep 28, 2013
View reviewed changes
vraptor-core/src/main/java/br/com/caelum/vraptor/view/LinkToHandler.java
Class<?> linkToInterface;
try {
linkToInterface = Class.forName(interfaceName);
} catch (ClassNotFoundException _) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the variable name =)

@garcia-jj
Copy link
Member

Please, merge as soon as possible. This new sintax is too pretty.

@garcia-jj garcia-jj mentioned this pull request Sep 29, 2013
Closed
@garcia-jj
Copy link
Member

🐑 ?

lucascs added a commit that referenced this pull request Sep 30, 2013
@lucascs
Merge pull request #143 from caelum/lc-better-linkTo
330a830 
Better linkTo syntax
@lucascs lucascs merged commit 330a830 into master Sep 30, 2013
@lucascs lucascs deleted the lc-better-linkTo branch September 30, 2013 16:13
@garcia-jj garcia-jj mentioned this pull request Sep 30, 2013
Closed
@Turini Turini modified the milestone: 4.0.0-beta-1 Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-beta-1
Development

Successfully merging this pull request may close these issues.
3 participants
@lucascs @garcia-jj @Turini