Fixes auth interceptor on MusicJungle #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p the flow when user is not logged in;
| @BeforeCall | ||
| public void intercept() throws InterceptionException { | ||
| @AroundCall | ||
| public void intercept(SimpleInterceptorStack stack) { |
There was a problem hiding this comment.
I didn't want to change it because I thought the problem was with my IDE so I left that way... Don't worry, I'll fix it :-)
|
So now, @lucascs? |
|
It's good now =) I'd only check if that |
|
I tried that, but it didn't work because there's no other interceptor catching ValidatorException. |
|
Bummer. |
|
Ok, sir! |
|
I just add a simple comment. Do you think it's enough? |
|
Ok. 🚢 |
|
Can we merge it? |
|
👍 |
rponte
added a commit
that referenced
this pull request
Oct 1, 2013
Fixes auth interceptor on MusicJungle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my tests on music-jungle when I access an URL not permitted I get this error:
When interceptor uses @BeforeCall it can't stop the flow of request when the user isn't logged in, so it's necessary to use @AroundCall instead.