-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XStream and Gson will scanned only if present #161
Conversation
Pretty nice!!
|
@@ -34,6 +34,22 @@ | |||
<exclude name="br.com.caelum.vraptor.interceptor.multipart.NullMultipartInterceptor"> | |||
<if-class-available name="javax.servlet.http.Part"/> | |||
</exclude> | |||
|
|||
<exclude name="br.com.caelum.vraptor.serialization.xstream.*"> | |||
<if-class-available name="com.thoughtworks.xstream.XStream"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should exclude if class not available, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, my bad. Copy and paste :). Fixed in next commit.
🎳 |
🥓 |
Tested in musicjungle works fine. If XStream is disabled and user makes a XML request, http 406 error is thrown, since there are no handlers for XML requests. |
XStream and Gson will scanned only if present
This pull request allow users to get better performance if application don't use serialization and deserialization. With this, serialization object will not loaded.