Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XStream and Gson will scanned only if present #161

Merged
merged 2 commits into from
Oct 3, 2013

Conversation

garcia-jj
Copy link
Member

This pull request allow users to get better performance if application don't use serialization and deserialization. With this, serialization object will not loaded.

@rponte
Copy link
Contributor

rponte commented Oct 3, 2013

Pretty nice!!
On Oct 2, 2013 6:57 PM, "Otávio Garcia" notifications@github.com wrote:

This pull request allow users to get better performance if application
don't use serialization and deserialization. With this, serialization

object will not loaded.

You can merge this Pull Request by running

git pull https://github.com/caelum/vraptor4 ot-optional-serialization

Or view, comment on, or merge it at:

#161
Commit Summary

  • XStream and Gson will scanned only if present

File Changes

Patch Links:

@@ -34,6 +34,22 @@
<exclude name="br.com.caelum.vraptor.interceptor.multipart.NullMultipartInterceptor">
<if-class-available name="javax.servlet.http.Part"/>
</exclude>

<exclude name="br.com.caelum.vraptor.serialization.xstream.*">
<if-class-available name="com.thoughtworks.xstream.XStream"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should exclude if class not available, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad. Copy and paste :). Fixed in next commit.

@Turini
Copy link
Member

Turini commented Oct 3, 2013

🎳

@lucascs
Copy link
Member

lucascs commented Oct 3, 2013

🥓

@garcia-jj
Copy link
Member Author

Tested in musicjungle works fine. If XStream is disabled and user makes a XML request, http 406 error is thrown, since there are no handlers for XML requests.

garcia-jj added a commit that referenced this pull request Oct 3, 2013
XStream and Gson will scanned only if present
@garcia-jj garcia-jj merged commit a2dd51e into master Oct 3, 2013
@garcia-jj garcia-jj deleted the ot-optional-serialization branch October 3, 2013 14:09
@Turini Turini added this to the 4.0.0-beta-2 milestone Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants