Better interceptor structure for multipart requests #176
Conversation
|
I don't think we should change internal interceptors to new way until we finish it is optimization. (The old way is like 5x faster). What do you think? |
|
5 times faster? Oh, I'll rollback to old way. :sad_panda: |
|
Reverted to old style. |
| protected File createTempFile() throws IOException { | ||
| return File.createTempFile("raptor.", ".upload"); | ||
|
|
||
| protected Path createDirInsideApplication() { |
There was a problem hiding this comment.
why not temp file? If the deploy is via war, in some servers it won't work. Temp files should always work (except when you are on GAE or other PaaS that doesn't allow files )
There was a problem hiding this comment.
it's only a typo, see the method getTemporaryDirectory that creates a temp file. I'll change the name.
There was a problem hiding this comment.
@lucascs, please see the method getTemporaryDirectory that creates a temp file, then return the parent. createDirInsideApplication it's a fallback method that creates a dir inside application when I can't file temp dir. This method is the same in current version on master. I didn't changed.
There was a problem hiding this comment.
Probably the old interceptor will always be faster... It's a direct a call
against a dynamic call... I do not see many ways to improve..
On Sat, Oct 5, 2013 at 1:04 PM, Otávio Garcia notifications@gitpro.ttaallkk.topwrote:
In
vraptor-core/src/main/java/br/com/caelum/vraptor/interceptor/multipart/DefaultMultipartConfig.java:}
- protected File createTempFile() throws IOException {
return File.createTempFile("raptor.", ".upload");- protected Path createDirInsideApplication() {
@lucascs https://github.com/lucascs, please see the method
getTemporaryDirectory that creates a temp file, then return the parent.
createDirInsideApplication it's a fallback method that creates a dir
inside application when I can't file temp dir. This method is the same in
current version on master. I didn't changed.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/176/files#r6784155
.
There was a problem hiding this comment.
@asouza I didn't understand your comment.
|
It seems fine by me 🚢 |
Better interceptor structure for multipart requests
Because we can use less code.