Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using java7 features #224

Merged
merged 6 commits into from
Oct 21, 2013
Merged

Using java7 features #224

merged 6 commits into from
Oct 21, 2013

Conversation

garcia-jj
Copy link
Member

No big changes. I only changed some code to use Java 7 features like diamonds, removing some warnings, etc.

@@ -396,7 +396,7 @@ public Void execute(RequestInfo request, int counter) {

Converters converters = currentContainer.instanceFor(Converters.class);

final HashMap<Class, Class<?>> EXPECTED_CONVERTERS = new HashMap<Class, Class<?>>() {
final HashMap<Class<?>, Class<?>> EXPECTED_CONVERTERS = new HashMap<Class<?>, Class<?>>() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diamond here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diamonds can't be used in anonymous classes.

@lucascs
Copy link
Member

lucascs commented Oct 21, 2013

besides the missing diamond, 👌

garcia-jj added a commit that referenced this pull request Oct 21, 2013
@garcia-jj garcia-jj merged commit a17d6fa into master Oct 21, 2013
@garcia-jj garcia-jj deleted the ot-using-java7-features branch October 21, 2013 21:33
@Turini Turini added this to the 4.0.0-beta-3 milestone Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants