Single managed InterceptorExecutor #244
Conversation
| } else { | ||
| stack.next(controllerMethod, currentController); | ||
| } | ||
| } | ||
|
|
||
| private Method find(Class<? extends Annotation> step) { |
There was a problem hiding this comment.
I think that find is too generic, but I don't have suggestion to a better name. What you think?
There was a problem hiding this comment.
maybe findMethodWith(AroundCall.class ...). looks better?
|
I don't have large knowledge in interceptorexecutor. But sounds like good for me. I really love these optimizations. |
Nice! Tks Otávio. 'll hold just a little more, to more revisions :) |
|
Have you check performance improvement with AB? |
Yes! Local running, reduces one second on time taken for tests |
| if(!around.accept()) around = new StackNextExecutor(simpleInterceptorStack); | ||
| if(!before.accept()) before = new DoNothingStepExecutor(); | ||
| private void extractAllInterceptorMethods() { | ||
| MirrorList<Method> methods = stepInvoker.findAllMethods(interceptorClass); |
There was a problem hiding this comment.
Do you really need MirrorList here? Why not just List?
Besides that 🍧
There was a problem hiding this comment.
Do you really need MirrorList here? Why not just List?
I really need :( stepInvoker.findMethod(...) uses
MirrorList to call .matching(new InvokeMatcher(step))
Single managed InterceptorExecutor
ghost
assigned 
Now we are using 1 managed app scoped executor,
instead of 4 non-managed for each interceptor handlers.